Fix confusing code in DeleteAll() #510
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #354 by simplifying the confusing implementation of the
DeleteAll()method inILinksExtensions.cs.Problem
The original implementation had confusing logic:
Issues with the old code:
i = --iin the for loop incrementif (links.Count() != --i)that decrementediagainSolution
Simplified to a much clearer implementation:
The new logic is straightforward:
ito the new count (which is now one less)Testing
Related Issue
Fixes #354
🤖 Generated with Claude Code