Skip to content

Fix confusing code in DeleteAll() #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix confusing code in DeleteAll() #510

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdaf25c
Initial commit with task details for issue #354
konard Oct 30, 2025
60a2787
Simplify confusing DeleteAll implementation
konard Oct 30, 2025
273957f
Revert "Initial commit with task details for issue #354"
konard Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions csharp/Platform.Data.Doublets/ILinksExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,9 @@ public static TLinkAddress Delete<TLinkAddress>(this ILinks<TLinkAddress> links,
public static void DeleteAll<TLinkAddress>(this ILinks<TLinkAddress> links) where TLinkAddress : IUnsignedNumber<TLinkAddress>
{
var comparer = Comparer<TLinkAddress>.Default;
for (var i = links.Count(); comparer.Compare(i, default) > 0; i = --i)
for (var i = links.Count(); comparer.Compare(i, default) > 0; i = links.Count())
{
links.Delete(i);
if (links.Count() != --i)
{
i = links.Count();
}
}
}

Expand Down
Loading