chore: update translations #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update translations Log: update translations
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR refreshes all .ts translation files for the dde-device-formatter by normalizing headers, bumping line references, filling in missing translations and dropping obsolete entries, plus adding new locale files. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Johnson-zs - I've reviewed your changes - here's some feedback:
- The newly added sq locale file is entirely marked unfinished and contains no translations yet—please either supply the actual translations or remove it from this PR to avoid blank UI text.
- Many TS headers were hand-edited (encoding, DOCTYPE, line numbers) which can lead to parser errors; consider regenerating all TS files with lupdate to keep headers and formatting consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The newly added sq locale file is entirely marked unfinished and contains no translations yet—please either supply the actual translations or remove it from this PR to avoid blank UI text.
- Many TS headers were hand-edited (encoding, DOCTYPE, line numbers) which can lead to parser errors; consider regenerating all TS files with lupdate to keep headers and formatting consistent.
## Individual Comments
### Comment 1
<location> `translations/dde-device-formatter_af.ts:17` </location>
<code_context>
+ <message>
+ <location filename="../view/formatingpage.cpp" line="29"/>
+ <source>Formatting the disk, please wait...</source>
+ <translation>Formaat van die skerm, asseblief wag...</translation>
+ </message>
+</context>
</code_context>
<issue_to_address>
Possible mistranslation of 'disk' as 'skerm' (screen) in Afrikaans.
'Skerm' should be replaced with 'skyf' to accurately translate 'disk.'
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
<translation>Formaat van die skerm, asseblief wag...</translation>
=======
<translation>Formateer die skyf, asseblief wag...</translation>
>>>>>>> REPLACE
</suggested_fix>
### Comment 2
<location> `translations/dde-device-formatter_af.ts:40` </location>
<code_context>
+ <message>
+ <location filename="../view/mainpage.cpp" line="144"/>
+ <source>Formatting will erase all data on the disk.</source>
+ <translation>Formaat sal alle data op die skerm verwyder.</translation>
+ </message>
+</context>
</code_context>
<issue_to_address>
Incorrect term 'skerm' (screen) used for 'disk' in Afrikaans.
Replace 'skerm' with 'skyf' to accurately refer to 'disk' and avoid user confusion.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
<translation>Formaat sal alle data op die skerm verwyder.</translation>
=======
<translation>Formaat sal alle data op die skyf verwyder.</translation>
>>>>>>> REPLACE
</suggested_fix>
### Comment 3
<location> `translations/dde-device-formatter_af.ts:135` </location>
<code_context>
+ <message>
+ <location filename="../view/warnpage.cpp" line="23"/>
+ <source>Formatting will erase all data on this disk, are you sure you want to continue? It cannot be restored.</source>
+ <translation>Formaat sal alle data op hierdie skerm verwyder, is u seker dat u wil voortgaan? Dit kan nie herstel word nie.</translation>
+ </message>
+</context>
</code_context>
<issue_to_address>
Repeated mistranslation of 'disk' as 'skerm' in warning message.
Please replace 'skerm' with 'skyf' in the translation for accuracy.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
<source>Formatting will erase all data on this disk, are you sure you want to continue? It cannot be restored.</source>
<translation>Formaat sal alle data op hierdie skerm verwyder, is u seker dat u wil voortgaan? Dit kan nie herstel word nie.</translation>
=======
<source>Formatting will erase all data on this disk, are you sure you want to continue? It cannot be restored.</source>
<translation>Formaat sal alle data op hierdie skyf verwyder, is u seker dat u wil voortgaan? Dit kan nie herstel word nie.</translation>
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <message> | ||
| <location filename="../view/formatingpage.cpp" line="29"/> | ||
| <source>Formatting the disk, please wait...</source> | ||
| <translation>Formaat van die skerm, asseblief wag...</translation> |
There was a problem hiding this comment.
suggestion (typo): Possible mistranslation of 'disk' as 'skerm' (screen) in Afrikaans.
'Skerm' should be replaced with 'skyf' to accurately translate 'disk.'
Suggested change
| <translation>Formaat van die skerm, asseblief wag...</translation> | |
| <translation>Formateer die skyf, asseblief wag...</translation> |
| <message> | ||
| <location filename="../view/mainpage.cpp" line="144"/> | ||
| <source>Formatting will erase all data on the disk.</source> | ||
| <translation>Formaat sal alle data op die skerm verwyder.</translation> |
There was a problem hiding this comment.
issue (typo): Incorrect term 'skerm' (screen) used for 'disk' in Afrikaans.
Replace 'skerm' with 'skyf' to accurately refer to 'disk' and avoid user confusion.
Suggested change
| <translation>Formaat sal alle data op die skerm verwyder.</translation> | |
| <translation>Formaat sal alle data op die skyf verwyder.</translation> |
Comment on lines
+134
to
+135
| <source>Formatting will erase all data on this disk, are you sure you want to continue? It cannot be restored.</source> | ||
| <translation>Formaat sal alle data op hierdie skerm verwyder, is u seker dat u wil voortgaan? Dit kan nie herstel word nie.</translation> |
There was a problem hiding this comment.
issue (typo): Repeated mistranslation of 'disk' as 'skerm' in warning message.
Please replace 'skerm' with 'skyf' in the translation for accuracy.
Suggested change
| <source>Formatting will erase all data on this disk, are you sure you want to continue? It cannot be restored.</source> | |
| <translation>Formaat sal alle data op hierdie skerm verwyder, is u seker dat u wil voortgaan? Dit kan nie herstel word nie.</translation> | |
| <source>Formatting will erase all data on this disk, are you sure you want to continue? It cannot be restored.</source> | |
| <translation>Formaat sal alle data op hierdie skyf verwyder, is u seker dat u wil voortgaan? Dit kan nie herstel word nie.</translation> |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update translations
Log: update translations
Summary by Sourcery
Update and complete translation resources for dde-device-formatter by standardizing TS file headers, synchronizing source references, and filling in missing strings across numerous locales.
Enhancements: