fix: AI translations update #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log: update translations file.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThe PR normalizes TS XML headers, updates per-message location line numbers, refreshes translation strings across all locale files and introduces a new “Your disk has been removed” message entry while marking the old formatting-removed message as vanished. Class diagram for translation message structure changesclassDiagram
class TS {
+version: string
+language: string
context: Context[]
}
class Context {
+name: string
message: Message[]
}
class Message {
+location: string
+source: string
+translation: string
+type: string (optional)
}
TS "1" -- "*" Context : contains
Context "1" -- "*" Message : contains
%% Highlight new/modified attributes
Message : +type ("vanished")
Message : +location (updated line numbers)
Message : +source = "Your disk has been removed" (added)
Message : +source = "Your disk is removed when formatting" (now vanished)
Class diagram for translation file header normalizationclassDiagram
class TS {
+xml_declaration: string (now always with encoding)
+doctype: string
+version: string
+language: string
}
%% The xml_declaration is now normalized to include encoding
TS : +xml_declaration = '<?xml version="1.0" encoding="utf-8"?>'
TS : +doctype = '<!DOCTYPE TS>'
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JWWTSL - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `translations/dde-device-formatter_kn_IN.ts:30` </location>
<code_context>
<location filename="../view/mainpage.cpp" line="117"/>
<source>Label</source>
- <translation>ನಿಶ್ಚಯಿಸಿ</translation>
+ <translation>ಅಂಶ</translation>
</message>
<message>
</code_context>
<issue_to_address>
Translation for 'Label' as 'ಅಂಶ' may be inaccurate.
'ಅಂಶ' translates to 'element' or 'part', which may not fit the context of 'Label' (e.g., disk label). Suggest using 'ಲೇಬಲ್' or 'ಚೀಟಿ' for accuracy.
</issue_to_address>
### Comment 2
<location> `translations/dde-device-formatter_kn_IN.ts:122` </location>
<code_context>
<location filename="../main.cpp" line="97"/>
<source>Device does not exist</source>
- <translation>ಸಾಧನ ಇದು ಅಸ್ತಿತ್ವದಲ್ಲಿಲ್ಲ</translation>
+ <translation>ವಸ್ತು ಇದೆಯಾ?</translation>
</message>
<message>
</code_context>
<issue_to_address>
Translation for 'Device does not exist' is a question, not a statement.
'ವಸ್ತು ಇದೆಯಾ?' translates to a question. Use 'ವಸ್ತು ಇಲ್ಲ' or 'ಸಾಧನ ಅಸ್ತಿತ್ವದಲ್ಲಿಲ್ಲ' for an accurate statement translation.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <location filename="../view/mainpage.cpp" line="117"/> | ||
| <source>Label</source> | ||
| <translation>ನಿಶ್ಚಯಿಸಿ</translation> | ||
| <translation>ಅಂಶ</translation> |
There was a problem hiding this comment.
issue: Translation for 'Label' as 'ಅಂಶ' may be inaccurate.
'ಅಂಶ' translates to 'element' or 'part', which may not fit the context of 'Label' (e.g., disk label). Suggest using 'ಲೇಬಲ್' or 'ಚೀಟಿ' for accuracy.
| <location filename="../main.cpp" line="97"/> | ||
| <source>Device does not exist</source> | ||
| <translation>ಸಾಧನ ಇದು ಅಸ್ತಿತ್ವದಲ್ಲಿಲ್ಲ</translation> | ||
| <translation>ವಸ್ತು ಇದೆಯಾ?</translation> |
There was a problem hiding this comment.
issue: Translation for 'Device does not exist' is a question, not a statement.
'ವಸ್ತು ಇದೆಯಾ?' translates to a question. Use 'ವಸ್ತು ಇಲ್ಲ' or 'ಸಾಧನ ಅಸ್ತಿತ್ವದಲ್ಲಿಲ್ಲ' for an accurate statement translation.
|
@JWWTSL: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log: update translations file.
Summary by Sourcery
Update AI-generated translations in TS files: standardize headers, adjust source locations, refine existing strings, and add the new 'Your disk has been removed' message.
New Features:
Enhancements:
Chores: