fix(tty): keyboard arrow keys not working in QTerminal#225
Merged
mister-teddy merged 2 commits intolocaldesktop:mainfrom Apr 7, 2026
Merged
fix(tty): keyboard arrow keys not working in QTerminal#225mister-teddy merged 2 commits intolocaldesktop:mainfrom
mister-teddy merged 2 commits intolocaldesktop:mainfrom
Conversation
The explicit --bind=/dev/pts:/dev/pts and --bind=/dev/ptmx:/dev/ptmx (added in upstream commit 61d9079 "fix: missing terminal") were redundant because --bind=/dev already covers all of /dev including its subdirectories. Having both caused proot to double-translate PTY ioctls (TIOCGPTN/TIOCSPTLCK/TIOCSWINSZ), which broke terminal initialisation inside QTerminal and made keyboard arrow keys stop working. Fix: remove the redundant sub-binds. Add --bind=/dev/tty:/dev/tty explicitly since some processes open /dev/tty by path rather than using the inherited file descriptor. TERM=xterm-256color is unchanged: infocmp confirms that xterm and xterm-256color have identical smkx/kcuu1 sequences. Arrow keys work via readline's hardcoded CSI bindings (\e[A) regardless of cursor mode. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
I think this is not really needed. Doesn't it work if you enable the accessibility service? |
Contributor
Author
|
Because of my security overlay, I can't enable accessibility in the app since it's not from the Play Store. |
mister-teddy
added
release:bugfix
Contributor
Me too 👍 The more the merrier 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: keyboard arrow keys not working in QTerminal
Arrow keys (↑ ↓ ← →) were not working inside QTerminal.
The root cause was two redundant proot bind mounts:
--bind=/dev/pts:/dev/ptsand--bind=/dev/ptmx:/dev/ptmx. Since--bind=/devalready covers all of/devincluding its subdirectories, these explicit sub-binds caused proot to double-translate PTY ioctls (TIOCGPTN, TIOCSPTLCK, TIOCSWINSZ), which broke terminal initialisation inside QTerminal.Changes:
/dev/ptsand/dev/ptmxbinds (covered by--bind=/dev)--bind=/dev/tty:/dev/ttyexplicitly, as some processes open it by path