Skip to content

fix(tty): keyboard arrow keys not working in QTerminal #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mister-teddy merged 2 commits into from
Apr 7, 2026
Merged

fix(tty): keyboard arrow keys not working in QTerminal #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be46941
fix(tty): remove redundant /dev/pts bind that broke PTY ioctls in proot
ArcheoCodix Apr 5, 2026
d17c359
Merge branch 'main' into fix/tty-keyboard
mister-teddy Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/android/proot/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,12 @@ impl ArchProcess {
.arg("--bind=/proc")
.arg("--bind=/sys")
.arg(format!("--bind={}/tmp:/dev/shm", config::ARCH_FS_ROOT))
.arg("--bind=/dev/pts:/dev/pts")
.arg("--bind=/dev/ptmx:/dev/ptmx");
// /dev/pts and /dev/ptmx are already covered by --bind=/dev above.
// The explicit sub-binds added in commit 61d9079 were redundant and caused
// proot to double-translate PTY ioctls (TIOCGPTN/TIOCSPTLCK/TIOCSWINSZ),
// breaking terminal initialisation and keyboard arrow keys inside QTerminal.
// We only need /dev/tty explicitly for processes that open it by path.
.arg("--bind=/dev/tty:/dev/tty");

if context.permission_all_files_access {
process
Expand Down
Loading