Update localgov_demo reference to localgov_services_menu#156
Open
andybroomfield wants to merge 1 commit into3.xfrom
Open
Update localgov_demo reference to localgov_services_menu#156andybroomfield wants to merge 1 commit into3.xfrom
andybroomfield wants to merge 1 commit into3.xfrom
Conversation
Fix #155 Use hypens for the menu name: `localgov-services-menu`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #155
Use hypens for the menu name:
localgov-services-menuThis is the counterpart to localgovdrupal/localgov_services#340
What does this change?
Changes the reference to the menu
localgov_services_menuto use the hyphen version.This is to match with a PR on localgov_services that will also make that change.
How to test
Install this branch and the corresponding localgov_services branch.
Running
drush si localgov -y; drush en localgov_demoshould install without issue.How can we measure success?
Menu name replaced and menu links remain added.
Have we considered potential risks?
We might have to make this version of localgov_demo depend on the corresponding version of localgov_services as a minimum version.
Images
Accessibility
n/a