Skip to content

DM-44144: Make sconsUtils standalone/pip-installable#125

Open
taranu wants to merge 22 commits intomainfrom
tickets/DM-44144
Open

DM-44144: Make sconsUtils standalone/pip-installable#125
taranu wants to merge 22 commits intomainfrom
tickets/DM-44144

Conversation

@taranu
Copy link

@taranu taranu commented May 1, 2024

No description provided.

@taranu taranu force-pushed the tickets/DM-44144 branch 5 times, most recently from 07c8ac6 to dbe0854 Compare May 2, 2024 00:17
@timj timj force-pushed the tickets/DM-44144 branch from dbe0854 to 967e9a8 Compare March 4, 2026 19:44
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.48%. Comparing base (47f0db3) to head (d04edcf).

Files with missing lines Patch % Lines
tests/test_single.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #125       +/-   ##
===========================================
+ Coverage   69.23%   79.48%   +10.25%     
===========================================
  Files           3        3               
  Lines          39       39               
  Branches        4        4               
===========================================
+ Hits           27       31        +4     
+ Misses          9        4        -5     
- Partials        3        4        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timj timj force-pushed the tickets/DM-44144 branch from 5837d90 to 181690c Compare March 4, 2026 19:52
@timj timj force-pushed the tickets/DM-44144 branch from b95e013 to d04edcf Compare March 4, 2026 23:59
Copy link
Author

@taranu taranu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, assuming it all works.


- name: Run tests
run: |
pytest --ignore=tests/test_simple.py -r a -v -n 3
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is a comment in test_simple.py explaining that they must be run with scons, but perhaps a comment here would be useful too. And perhaps it should be called test_with_scons.py or something more obvious?

- name: Update pip/wheel infrastructure
run: |
python -m pip install --upgrade pip uv
uv pip install --system wheel
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm vaguely aware that uv is supposed to be better than pip alone but is uv pip basically just for speed like mamba vs conda used to be, or are there other advantages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants