-
Notifications
You must be signed in to change notification settings - Fork 11
DM-44144: Make sconsUtils standalone/pip-installable #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taranu
wants to merge
22
commits into
main
Choose a base branch
from
tickets/DM-44144
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1b6ad24
Add more build and IDE paths to .gitignore
taranu 706d38a
Add license files
taranu 60297df
Update project configuration to make package standalone
taranu 49dec5e
Update README as markdown
taranu 0371534
Add COPYRIGHT file
taranu 1ff3d54
Add copyright preambles
taranu a9e3b32
Add no-inheritance-diagram to automodapi sections
taranu f3195ca
Update contributing link to cloud Jira
taranu 845126e
Add build_and_test_pip github action
taranu ee80e2e
Switch GHA pip build to stop using conda
timj 0201b0a
Note that the tests must be run via scons
timj a1fff6e
Rename test file to allow it to be found
timj 510a7ac
Ignore the test that requires that the test is run from scons
timj a02f1b8
Run pip tests with scons as well
timj 6be65ac
Some fixes to license and version info
timj f68315d
Remove pex_config mention
timj 022650f
Ignore dist dir
timj 8834af8
Add PyPI to action
timj d1c774f
edit readme
timj 355254d
Switch to documenteer 2
timj e484623
Ignore doc/api dir
timj d04edcf
Enable doc build action
timj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| name: docs | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| build_sphinx_docs: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| # Need to clone everything for the git tags. | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: "3.13" | ||
| cache: "pip" | ||
| cache-dependency-path: "setup.cfg" | ||
|
|
||
| - name: Install graphviz | ||
| run: sudo apt-get install graphviz | ||
|
|
||
| - name: Update pip/wheel infrastructure | ||
| run: | | ||
| python -m pip install --upgrade pip uv | ||
| uv pip install --system wheel | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm vaguely aware that uv is supposed to be better than pip alone but is |
||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| uv pip install --system -r requirements.txt | ||
|
|
||
| - name: Build and install | ||
| run: uv pip install --system --no-deps -v . | ||
|
|
||
| - name: Install documenteer | ||
| run: uv pip install --system -r doc/requirements.txt | ||
|
|
||
| - name: Build documentation | ||
| working-directory: ./doc | ||
| run: package-docs build | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Copyright 2024 Association of Universities for Research in Astronomy, Inc. (AURA) | ||
| Copyright 2024 The Trustees of Princeton University |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| This software is dual licensed under the GNU General Public License and also | ||
| under a 3-clause BSD license. Recipients may choose which of these licenses | ||
| to use; please see the files gpl-3.0.txt and/or bsd_license.txt, respectively. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # lsst-sconsUtils | ||
|
|
||
| [](https://codecov.io/gh/lsst/sconsUtils) | ||
|
|
||
| sconsUtils is a package in the [LSST Science Pipelines](https://pipelines.lsst.io/). | ||
|
|
||
| This package contains utility scripts for building pipelines packages with | ||
| [SCons](https://scons.org/), and is required to build most pipelines packages. | ||
| SCons can be used to build C++ and Python (with pybind11 bindings) packages; | ||
| see the [stack package templates](https://github.com/lsst/templates/tree/main/project_templates/stack_package) | ||
| if this is of interest. | ||
|
|
||
| This is a **Python 3 only** package. | ||
|
|
||
| This software is dual licensed under the GNU General Public License | ||
| (version 3 of the License, or (at your option) any later version), | ||
| and also under a 3-clause BSD license. Recipients may choose which of these | ||
| licenses to use; please see the files gpl-3.0.txt and/or bsd_license.txt, | ||
| respectively. | ||
|
|
||
| This package can only be imported through a SCons script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| For copyright information see the COPYRIGHT file included in the top-level | ||
| directory of this distribution. | ||
|
|
||
| Redistribution and use in source and binary forms, with or without modification, | ||
| are permitted provided that the following conditions are met: | ||
|
|
||
| 1. Redistributions of source code must retain the above copyright notice, | ||
| this list of conditions and the following disclaimer. | ||
|
|
||
| 2. Redistributions in binary form must reproduce the above copyright | ||
| notice, this list of conditions and the following disclaimer in the | ||
| documentation and/or other materials provided with the distribution. | ||
|
|
||
| 3. Neither the names of the copyright holders nor the names of their | ||
| contributors may be used to endorse or promote products derived from | ||
| this software without specific prior written permission. | ||
|
|
||
| THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND | ||
| ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED | ||
| WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
| DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE LIABLE | ||
| FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
| DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
| SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
| OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| [project] | ||
| title = "lsst-sconsUtils" | ||
|
|
||
| [project.python] | ||
| package = "lsst-sconsUtils" | ||
|
|
||
| [build] | ||
| clean = true | ||
|
|
||
| [sphinx] | ||
|
|
||
| nitpick_ignore = [ | ||
| ] | ||
| nitpick_ignore_regex = [ | ||
| ] | ||
|
|
||
| [sphinx.intersphinx.projects] | ||
| python = "https://docs.python.org/3" | ||
| scons = "https://scons.org/doc/4.10.0/HTML/scons-api/" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| lsst-sphinxutils @ git+https://github.com/lsst/sphinxutils@main |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there is a comment in test_simple.py explaining that they must be run with scons, but perhaps a comment here would be useful too. And perhaps it should be called test_with_scons.py or something more obvious?