openhcl_boot: set aside private pool memory based on heuristics #2215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkur
added a commit
that referenced
this pull request
Oct 22, 2025
Promote the settings that change how VTL2 memory is allocated to the Petri VM objects, rather than being hidden in the depths of the OpenVMM config. This is a convenience for additional tests coming as part of #2215 .
mattkur
added
the
release-ci-required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements heuristic-based private pool memory allocation for OpenHCL boot, allowing the system to automatically determine appropriate DMA memory sizes when not explicitly specified by external sources. The changes enable OpenHCL to retrofit private pool memory into existing deployments that don't explicitly configure it.
Key Changes:
- Adds a lookup table and calculation logic for determining VTL2 DMA hint values based on VP count and memory size
- Updates the boot parameter logic to use heuristics when neither command line nor device tree specify pool sizes
- Extends VMM tests to validate private pool behavior with various configurations
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| openhcl/openhcl_boot/src/host_params/dt/dma_hint.rs | New module implementing DMA hint calculation with lookup table and extrapolation logic |
| openhcl/openhcl_boot/src/host_params/dt/mod.rs | Integrates DMA hint calculation into boot parameter processing with fallback to heuristics |
| openhcl/openhcl_boot/Cargo.toml | Adds test dependencies for tracing support in unit tests |
| vmm_tests/vmm_tests/tests/tests/x86_64/openhcl_uefi.rs | Adds new test cases and extends test helper to support configurable processor topology and VTL2 memory sizes |
| petri/src/vm/mod.rs | Adds Debug derive to ProcessorTopology for improved test diagnostics |
mattkur
commented
Oct 24, 2025
smalis-msft
reviewed
Oct 24, 2025
smalis-msft
reviewed
Oct 24, 2025
smalis-msft
reviewed
Oct 24, 2025
smalis-msft
reviewed
Oct 24, 2025
amy-microsoft
previously approved these changes
Oct 30, 2025
amy-microsoft
left a comment
amy-microsoft
left a comment
There was a problem hiding this comment.
Nothing jumps out to me, but happy for others' opinions!
chris-oo
reviewed
Oct 30, 2025
chris-oo
reviewed
Oct 30, 2025
chris-oo
approved these changes
Oct 30, 2025
mattkur
added a commit
to mattkur/openvmm
that referenced
this pull request
Nov 3, 2025
…cs (microsoft#2215)" This reverts commit dcd23e2.
mattkur
added a commit
to mattkur/openvmm
that referenced
this pull request
Nov 3, 2025
…ics (microsoft#2215)" (microsoft#2339) This reverts commit c552f9a.
mattkur
added a commit
to mattkur/openvmm
that referenced
this pull request
Nov 4, 2025
…ics (microsoft#2215)" (microsoft#2339) This reverts commit c552f9a.
mattkur
added a commit
that referenced
this pull request
Nov 4, 2025
This re-appplies #2215, now that we've figured out the CI issues (I hope). - **vmm_tests: add large nvme relay tests** - **test fix, pr feedback** - **up the vm memory** - **tests: correctly mark heavy and very_heavy tests as heavy and very_heavy** - **Reapply "openhcl_boot: set aside private pool memory based on heuristics (#2215)" (#2339)**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With many thanks, this comes from @yupavlen-ms's PR #1190 . Other parts of his PR have been split out or handed in different ways.
TODO: