ci: add very_heavy test class, and write about test monikers in the guide #2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a very_heavy test classification for VMM tests that require more resources than the existing heavy category, and adds documentation explaining test resource requirements and naming conventions.
Key changes:
- Added
very_heavytest class in nextest configuration with 35 thread allocation for tests with ~32 VPs - Updated
heavytest filter to excludevery_heavytests from matching - Added comprehensive documentation about test monikers and resource allocation guidelines
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Guide/src/dev_guide/tests/vmm.md | Added new "heavy tests" section documenting test classification and moved "Writing VMM Tests" section earlier in the document |
| .config/nextest.toml | Added very_heavy test override with 35 threads and updated heavy filter to exclude very_heavy tests |
7 tasks
alandau
previously approved these changes
Oct 24, 2025
Contributor
alandau
left a comment
alandau
left a comment
There was a problem hiding this comment.
Thanks for adding docs. TIL.
smalis-msft
reviewed
Oct 27, 2025
Contributor
smalis-msft
left a comment
smalis-msft
left a comment
There was a problem hiding this comment.
LGTM, but could you also go mark the largevp memstat test as very_heavy now? IIRC it does 32 vps, and it's just 'heavy' for the moment.
smalis-msft
approved these changes
Oct 27, 2025
smalis-msft
pushed a commit
that referenced
this pull request
Oct 27, 2025
As recommended in #2256, mark the memstat LargeVp tests as very_heavy (since they use 32 or 64 vps).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In authoring #2215, I found that it would be useful to have a sense of what
constitutes a heavy test. I will also need a very_heavy category. Add that
category, and make a note of this in our dev guide.