Open
Conversation
github-actions
bot
added
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tido64
force-pushed
the
tido/oxlint
branch
2 times, most recently
from
6256ae0 to
9666a62
Compare
github-actions
bot
added
feature: metro
github-actions
bot
added
feature: align-deps
tido64
force-pushed
the
tido/oxlint
branch
3 times, most recently
from
bdb1b93 to
22ad061
Compare
Saadnajmi
approved these changes
Mar 2, 2026
vmoroz
reviewed
Mar 2, 2026
| @@ -41,6 +41,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@rnx-kit/eslint-config": "*", | |||
Member
There was a problem hiding this comment.
If we keep the eslint config, then we should keep the ESLint exclusions too.
Currently if I run the ESLint for the fork-sync it will fail because the important suppressions are removed.
IMHO, we either should do the complete conversion, or keep the old suppressions if we want to support both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shareable oxlint configurations.
The
README.mdcan be found here: https://github.com/microsoft/rnx-kit/blob/tido/oxlint/packages/oxlint-config/README.mdLocally, repo-wide linting is about ~5 seconds faster (~25s → ~20s) on my MacBook Pro. Unlike oxfmt, we prefer to run oxlint per package to allow type-aware checks (they need to read
tsconfig.json). On CI, the times vary too much to be conclusive:Test plan
CI should pass.