-
Notifications
You must be signed in to change notification settings - Fork 116
feat: shareable oxlint config #3996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@rnx-kit/oxlint-config": major | ||
| --- | ||
|
|
||
| Shareable oxlint configurations |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,4 +75,5 @@ catalog: | |
| eslint: ^9.0.0 | ||
| jest: ^29.2.1 | ||
| oxfmt: ^0.35.0 | ||
| oxlint: ^1.50.0 | ||
| typescript: ^5.0.0 | ||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import config from "@rnx-kit/oxlint-config/private"; | ||
| import { defineConfig } from "oxlint"; | ||
|
|
||
| export default defineConfig({ | ||
| extends: [config], | ||
| rules: { | ||
| // fork-sync uses interfaces extensively; allow both interface and type | ||
| "typescript/consistent-type-definitions": "off", | ||
| "no-new-array": "off", | ||
| }, | ||
| overrides: [ | ||
| { | ||
| files: ["eslint.config.js", "oxlint.config.ts"], | ||
| rules: { | ||
| "import/no-default-export": "off", | ||
| }, | ||
| }, | ||
| { | ||
| files: ["test/proc.test.ts", "test/tty-ui.test.ts"], | ||
| rules: { | ||
| "no-control-regex": "off", | ||
| }, | ||
| }, | ||
| ], | ||
| }); |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we keep the eslint config, then we should keep the ESLint exclusions too.
Currently if I run the ESLint for the fork-sync it will fail because the important suppressions are removed.
IMHO, we either should do the complete conversion, or keep the old suppressions if we want to support both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fork-sync is the only package where I've left in the ESLint support for now. I wasn't sure whether you're still relying on it. The old suppressions should've been kept in. I simply missed them.