Send notifications even when we're unpackaged#19937
Send notifications even when we're unpackaged#19937zadjii-msft wants to merge 3 commits intodev/migrie/fhl-spring26/bellStyle-notificationfrom
Conversation
|
big s/o to @shanselman who had this in Toasty and I copied liberally ❤️ |
This comment has been minimized.
This comment has been minimized.
…v/migrie/fhl-spring26/unpackaged-notify
| LOG_IF_FAILED(SetCurrentProcessExplicitAppUserModelID(L"Microsoft.WindowsTerminal")); | ||
| #elif defined(WT_BRANDING_PREVIEW) | ||
| LOG_IF_FAILED(SetCurrentProcessExplicitAppUserModelID(L"Microsoft.WindowsTerminalPreview")); | ||
| #elif defined(WT_BRANDING_CANARY) | ||
| LOG_IF_FAILED(SetCurrentProcessExplicitAppUserModelID(L"Microsoft.WindowsTerminalCanary")); | ||
| #else | ||
| LOG_IF_FAILED(SetCurrentProcessExplicitAppUserModelID(L"Microsoft.WindowsTerminalDev")); |
There was a problem hiding this comment.
how does this work for different versions of portable mode? we have already (and a couple times) fixed issues where portable and unpackaged have "crosstalk". See how we generate the Window ID in the WindowEmperor.
There was a problem hiding this comment.
This identifier allows an application to group its associated processes and windows under a single taskbar button.
for example, we do not want different instances of portable mode or unpackaged to glom together with packaged or with eachother.
| @@ -70,6 +71,7 @@ | |||
| "audible", | |||
| "taskbar", | |||
| "window", | |||
| "notification", | |||
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
added
the
No-Recent-Activity
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
2 participants
Targets #19936
Manually assign an AUMID to our process when we're running unpackaged. That'll let us actually send Windows notifications when we're unpackaged.