Refactor JSON Parsing to Use Boost.JSON #197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharityKathure
force-pushed
the
boost-parsing
branch
2 times, most recently
from
14cee0e to
9ea9ef9
Compare
profnandaa
reviewed
Oct 22, 2024
|
|
||
| const boost::json::array& providers = source.at("providers").as_array(); | ||
| for (const auto& provider : providers) { | ||
| std::string providerName = provider.as_object().at("providerName").as_string().c_str(); |
Contributor
There was a problem hiding this comment.
qq: btw, what happens when someone mixes the cases the names eg. ProviderName instead of providerName?
TinaMor
reviewed
Oct 22, 2024
|
|
||
| // Process channels if they exist | ||
| if (source.as_object().contains("channels")) { | ||
| std::vector<EventLogChannel>* channels = new std::vector<EventLogChannel>(); |
Contributor
There was a problem hiding this comment.
Could we avoid dynamic memory memory management because of memory leaks?
https://learnmoderncpp.com/2024/08/05/memory-allocation-techniques-in-modern-c/
| ) | ||
| ); | ||
|
|
||
| std::shared_ptr<SourceProcess> sourceProcess = std::make_shared< SourceProcess>(); |
Contributor
There was a problem hiding this comment.
std::unique_ptr perhaps since ownership is not shared?
Signed-off-by: Charity Kathure <ckathure@microsoft.com>
CharityKathure
force-pushed
the
boost-parsing
branch
from
fc1ddfa to
433d70c
Compare
Signed-off-by: Charity Kathure <ckathure@microsoft.com>
Signed-off-by: Charity Kathure <ckathure@microsoft.com>
Contributor
Author
|
Closing this PR to open a new one targeting a branch specifically for version 2.2.0rc.: #202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the JSON file parsing logic in the codebase, replacing custom parsers with the more robust and efficient Boost.JSON library. The switch to Boost.JSON simplifies the code by leveraging a well-maintained and high-performance library, improving maintainability, readability, and performance.
STDOUT after change:
