-
Notifications
You must be signed in to change notification settings - Fork 69
Refactor JSON Parsing to Use Boost.JSON #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1aaea68 to
d4cc8d5
Compare
Signed-off-by: Charity Kathure <ckathure@microsoft.com>
e26ec38 to
49748b2
Compare
b543202 to
8525c9d
Compare
Signed-off-by: Charity Kathure <ckathure@microsoft.com>
adbdcb4 to
d24fc9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the
LogMonitorproject, primarily focusing on replacing theConfigFileParserandJsonFileParserwith a newJsonProcessormodule. This includes the addition of new functions for handling different log types and updating the project files accordingly.New
JsonProcessormodule:JsonProcessor.cppwith functions to load, parse, and process JSON configuration files, handling different log types such as EventLog, File, ETW, and Process logs.JsonProcessor.hwith declarations for the new functions inJsonProcessor.cpp.Project file updates:
LogMonitor.vcxprojto includeJsonProcessor.cppandJsonProcessor.h, and removed references toConfigFileParser.cppandJsonFileParser.cpp. [1] [2]LogMonitorTests.vcxprojto includeJsonProcessorTests.cppand removed references toConfigFileParserTests.cpp. [1] [2]Test updates:
JsonProcessorTestsinJsonProcessorTests.cppto test the newJsonProcessorfunctionalities.LogMonitorTests.cppto remove the inclusion ofConfigFileParser.cpp.Codebase simplification:
Main.cppto useloadAndProcessJsoninstead ofOpenConfigFilefor reading the configuration file.These changes aim to enhance the functionality and maintainability of the
LogMonitorproject by introducing a more robust JSON processing module.