Merged
Conversation
We see more cases of this issue, I think the case is more fatal than before so now we just error but at least print the invalid json when we hit it. Warnings are still ignored ROCm/amdsmi#114
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Sep 10, 2025
For modular/rules_mojo#52 MODULAR_ORIG_COMMIT_REV_ID: c51d763ce7962fc01a4f011d4cdf2046921c232d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We see more cases of this issue, I think the case is more fatal than
before so now we just error but at least print the invalid json when we
hit it. Warnings are still ignored
ROCm/amdsmi#114