Skip to content

Try harder to handle amd-smi invalid json #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keith merged 1 commit into from
Sep 10, 2025
Merged

Try harder to handle amd-smi invalid json #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mojo/mojo_host_platform.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,10 @@ def _impl(rctx):
if line.startswith("WARNING:"):
continue
json_lines.append(line)
blob = json.decode("\n".join(json_lines))
failure_sentinel = {"DECODE": "FAILED"}
blob = json.decode("\n".join(json_lines), default = failure_sentinel)
if blob == failure_sentinel:
fail("amd-smi output was not valid json, please report this issue: {}".format(result.stdout))
if len(blob) == 0:
fail("amd-smi succeeded but didn't actually have any GPUs, please report this issue")

Expand Down