Fix image rotation on upload #16786
Open
Fix image rotation on upload #16786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey, really nice! About once a year I get a client asking me why the photo they just uploaded is rotated on their website. |
Collaborator
|
@MrRoco - Can you specify at least one software package that does not correctly save the data? That'll help in testing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Added an Exif check for edited images and if the have been Orientated.
If Orientated, make sure the image is also saved with the correct data.
Why is it needed?
Certain software doesn't save the edit data correctly which will cause rotated imaged to be reverted back after upload.
How to test
Rotate an image, upload it to the site, check if the image is still in correct position.
Related issue(s)/PR(s)
Resolves: #16785 and also resolves #15484