Skip to content

Fix image rotation on upload #16786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Fix image rotation on upload #16786

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef7fb10
Fix edited image being restored to before edit on image upload.
MrRoco Nov 19, 2025
b588529
Add doc line
MrRoco Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion core/src/Revolution/Sources/modMediaSource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
use xPDO\Cache\xPDOCacheManager;
use xPDO\Om\xPDOCriteria;
use xPDO\xPDO;
use MODX\Revolution\modPhpThumb;

/**
* An abstract base class extend to implement loading your League\Flysystem\AbstractAdapter
Expand Down Expand Up @@ -1181,8 +1182,29 @@ public function uploadObjectsToContainer($container, array $objects = [])
$this->xpdo->log(modX::LOG_LEVEL_ERROR, $e->getMessage());
}

// Check if Orientation is correct due to EXIF issues in JPG/JPEG and rotate if needed.
try {
$this->filesystem->write($newPath, file_get_contents($file['tmp_name']));
$image_extensions = ['jpg', 'jpeg'];
$file_extension = strtolower(pathinfo($file['name'], PATHINFO_EXTENSION));

if (in_array($file_extension, $image_extensions)) {
$exif = @exif_read_data($file['tmp_name']);
if (!empty($exif['Orientation']) && $exif['Orientation'] > 1) {
$phpThumb = new modPhpThumb($this->xpdo, []);
$phpThumb->setSourceFilename($file['tmp_name']);
$phpThumb->setParameter('ar', 'x');
if ($phpThumb->GenerateThumbnail()) {
$image_string = $phpThumb->OutputThumbnailData();
$this->filesystem->write($newPath, $image_string);
} else {
$this->filesystem->write($newPath, file_get_contents($file['tmp_name']));
}
} else {
$this->filesystem->write($newPath, file_get_contents($file['tmp_name']));
}
} else {
$this->filesystem->write($newPath, file_get_contents($file['tmp_name']));
}
} catch (FilesystemException | UnableToWriteFile $e) {
$this->addError('path', $this->xpdo->lexicon('file_err_upload'));
$this->xpdo->log(modX::LOG_LEVEL_ERROR, $e->getMessage());
Expand Down