fix(settings): prevent API key duplication on save by localai-bot · Pull Request #9080 · mudler/LocalAI

localai-bot · 2026-03-19T22:15:50Z

Description

Fixes issue #9071 where saving settings from the WebUI would duplicate API keys.

Problem

The Settings.jsx page stores API keys in a textarea as (string), but the backend expects an array in . When saving, the string was being sent directly instead of being converted to an array, causing duplication issues.

Solution

In the function, convert to an array before saving
Split the text by newlines, trim each key, and filter out empty strings
Set to an empty array when no keys are provided

Changes

Modified:

Testing

Save settings with multiple API keys (one per line)
Verify keys are saved correctly without duplication
Test with empty API keys field

netlify · 2026-03-19T22:15:56Z

✅ Deploy Preview for localai ready!

Name	Link
🔨 Latest commit	`e2ae3d2`
🔍 Latest deploy log	https://app.netlify.com/projects/localai/deploys/69bd07c8482fe600082ea72c
😎 Deploy Preview	https://deploy-preview-9080--localai.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Prevents API key duplication when saving settings by converting the WebUI textarea value into the backend’s expected api_keys array format.

Changes:

Build a settingsToSave payload before saving.
Parse api_keys_text into a trimmed, newline-split api_keys array (or [] when empty).
Save the normalized payload via settingsApi.save(settingsToSave).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-19T22:36:34Z

core/http/react-ui/src/pages/Settings.jsx

+        } else {
+          settingsToSave.api_keys = []
+        }
+      }


settingsToSave still includes api_keys_text (copied from settings). If api_keys_text is a UI-only field, sending it to the backend can cause schema/validation issues or unintended persistence. Consider deleting api_keys_text from settingsToSave before calling settingsApi.save, so the payload matches the backend contract (api_keys only).

Suggested change

}

}

// Remove UI-only field before sending to backend

delete settingsToSave.api_keys_text

Copilot · 2026-03-19T22:36:34Z

core/http/react-ui/src/pages/Settings.jsx

+      if (settingsToSave.api_keys_text !== undefined && settingsToSave.api_keys_text !== null) {
+        const text = settingsToSave.api_keys_text
+        if (typeof text === 'string' && text.trim() !== '') {
+          settingsToSave.api_keys = text.split('\n').map(k => k.trim()).filter(k => k !== '')


This normalizes whitespace/empties, but it doesn’t prevent duplicate keys within the textarea itself (e.g., the same key repeated on multiple lines). Since this PR targets duplication behavior, consider de-duplicating the resulting array (e.g., via a Set) to ensure api_keys is unique before saving.

Suggested change

settingsToSave.api_keys = text.split('\n').map(k => k.trim()).filter(k => k !== '')

const keys = text.split('\n').map(k => k.trim()).filter(k => k !== '')

settingsToSave.api_keys = Array.from(new Set(keys))

localai-bot · 2026-03-19T23:40:52Z

Fixes Applied

Addressed Copilot review comments:

Removed api_keys_text field: Now deletes from the payload before saving to avoid schema/validation issues
Deduplicated API keys: Uses to ensure unique API keys before saving

These changes ensure the backend receives only the normalized array without duplicate entries or UI-only fields.

localai-bot · 2026-03-19T23:44:07Z

Fixes Applied

Addressed Copilot review comments:

Removed api_keys_text field: Now deletes api_keys_text from the payload before saving to avoid schema/validation issues
Deduplicated API keys: Uses Array.from(new Set(keys)) to ensure unique API keys before saving

These changes ensure the backend receives only the normalized api_keys array without duplicate entries or UI-only fields.

localai-bot · 2026-03-20T02:21:19Z

I've addressed the Copilot review comments:

Deduplicated API keys: Added to ensure unique keys before saving
Removed UI-only field: Added before sending to backend to prevent schema/validation issues

Changes have been pushed to the branch. The PR should now be ready for review.

localai-bot · 2026-03-20T02:22:52Z

I have addressed the Copilot review comments:

Deduplicated API keys using Set before saving
Removed api_keys_text (UI-only field) from payload before backend call

Changes have been pushed to the branch. The PR should now be ready for review.

localai-bot · 2026-03-20T07:47:54Z

✅ DCO Check Fixed

The DCO check was failing due to a mismatch between the committer email and Signed-off-by email. I've fixed this by:

Rewriting all commits in the branch using WARNING: git-filter-branch has a glut of gotchas generating mangled history
rewrites. Hit Ctrl-C before proceeding to abort, then use an
alternative filtering tool such as 'git filter-repo'
(https://github.com/newren/git-filter-repo/) instead. See the
filter-branch manual page for more details; to squelch this warning,
set FILTER_BRANCH_SQUELCH_WARNING=1.
Proceeding with filter-branch...
Setting the committer email to match the Signed-off-by email:
Adding proper Signed-off-by lines to all commits

The DCO check is now passing. The branch has been force-pushed and the PR is updated automatically.

All other checks are passing. Ready for review!

- Convert api_keys_text (textarea input) to api_keys array before saving - Split text by newlines and trim each key to avoid duplicates - Set api_keys to empty array when no keys are provided - This fixes the issue where saving settings would duplicate API keys because the backend expects an array, not a text string Signed-off-by: localai-bot <localai-bot@localai.io>

…e UI-only field - Use Set to deduplicate API keys before saving - Delete api_keys_text from payload before sending to backend - Addresses feedback from Copilot review comments Signed-off-by: localai-bot <localai-bot@localai.io>

localai-bot · 2026-03-20T08:40:12Z

Merge Conflict Resolution

I've resolved the merge conflicts by rebasing the branch on top of the latest upstream/master.

Actions Taken:

Rebased the branch fix-settings-api-keys-dup on top of upstream/master
All conflicts resolved automatically (no manual intervention needed)
Force-pushed the rebased branch to the fork

Current Status:

Branch now includes all commits from upstream/master
Your changes (API key deduplication fix) are preserved on top of the latest code
Ready for review and merge

The PR should now show as mergeable. Please review and merge when ready!

mudler requested a review from Copilot March 19, 2026 22:30

Copilot AI reviewed Mar 19, 2026

View reviewed changes

Copilot started reviewing on behalf of mudler March 19, 2026 22:53 View session

localai-bot force-pushed the fix-settings-api-keys-dup branch from 36d175d to 01a8524 Compare March 20, 2026 01:12

localai-bot force-pushed the fix-settings-api-keys-dup branch 5 times, most recently from 98b603e to 06c1eee Compare March 20, 2026 07:45

localai-bot added 2 commits March 20, 2026 08:37

localai-bot force-pushed the fix-settings-api-keys-dup branch from 06c1eee to e2ae3d2 Compare March 20, 2026 08:39

localai-bot added this to LocalAI Agent team Mar 20, 2026

localai-bot moved this to In review in LocalAI Agent team Mar 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(settings): prevent API key duplication on save#9080

fix(settings): prevent API key duplication on save#9080
localai-bot wants to merge 2 commits intomudler:masterfrom
localai-bot:fix-settings-api-keys-dup

localai-bot commented Mar 19, 2026

Uh oh!

netlify bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 19, 2026

Uh oh!

Copilot AI Mar 19, 2026

Uh oh!

localai-bot commented Mar 19, 2026

Uh oh!

localai-bot commented Mar 19, 2026

Uh oh!

localai-bot commented Mar 20, 2026

Uh oh!

localai-bot commented Mar 20, 2026

Uh oh!

localai-bot commented Mar 20, 2026

Uh oh!

localai-bot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-      }
+      }
+      // Remove UI-only field before sending to backend
+      delete settingsToSave.api_keys_text

	settingsToSave.api_keys = text.split('\n').map(k => k.trim()).filter(k => k !== '')
	const keys = text.split('\n').map(k => k.trim()).filter(k => k !== '')
	settingsToSave.api_keys = Array.from(new Set(keys))

Uh oh!

Conversation

localai-bot commented Mar 19, 2026

Description

Problem

Solution

Changes

Testing

Uh oh!

netlify bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for localai ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

localai-bot commented Mar 19, 2026

Fixes Applied

Uh oh!

localai-bot commented Mar 19, 2026

Fixes Applied

Uh oh!

localai-bot commented Mar 20, 2026

Uh oh!

localai-bot commented Mar 20, 2026

Uh oh!

localai-bot commented Mar 20, 2026

Uh oh!

localai-bot commented Mar 20, 2026

Merge Conflict Resolution

Actions Taken:

Current Status:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Mar 19, 2026 •

edited

Loading