Skip to content

fix(settings): prevent API key duplication on save #9080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
localai-bot wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −1
Open

fix(settings): prevent API key duplication on save #9080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97b3ef0
fix(settings): prevent API key duplication on save
Mar 19, 2026
e2ae3d2
fix: address Copilot review feedback - deduplicate API keys and remov…
Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion core/http/react-ui/src/pages/Settings.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,20 @@ export default function Settings() {
const handleSave = async () => {
setSaving(true)
try {
await settingsApi.save(settings)
// Prepare settings for saving: convert api_keys_text to api_keys array
const settingsToSave = { ...settings }
if (settingsToSave.api_keys_text !== undefined && settingsToSave.api_keys_text !== null) {
const text = settingsToSave.api_keys_text
if (typeof text === 'string' && text.trim() !== '') {
const keys = text.split('\n').map(k => k.trim()).filter(k => k !== '')
settingsToSave.api_keys = Array.from(new Set(keys))
} else {
settingsToSave.api_keys = []
}
}
Copy link

Copilot AI Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

settingsToSave still includes api_keys_text (copied from settings). If api_keys_text is a UI-only field, sending it to the backend can cause schema/validation issues or unintended persistence. Consider deleting api_keys_text from settingsToSave before calling settingsApi.save, so the payload matches the backend contract (api_keys only).

Suggested change
}
}
// Remove UI-only field before sending to backend
delete settingsToSave.api_keys_text

Copilot uses AI. Check for mistakes.
// Remove UI-only field before sending to backend
delete settingsToSave.api_keys_text
await settingsApi.save(settingsToSave)
addToast('Settings saved successfully', 'success')
} catch (err) {
addToast(`Save failed: ${err.message}`, 'error')
Expand Down
Loading