-
-
Notifications
You must be signed in to change notification settings - Fork 277
[Toast] Fix Toast.Description not rendering when a custom component is passed #2977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size report
|
|
We should add a test for this |
added 👍 |
| it('renders the description when passed to render prop', async () => { | ||
| function CustomList() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Title component has the same issue
|
This will render the element if you do |
Got it, as changes in this PR are improved version compared to master branch and considering there isn't elegant way to detect your edge case, should we merge this or keep current changes as is and think of better solution. |
closes #2809
Before
https://codesandbox.io/p/sandbox/compassionate-sid-vz7mmz?file=%2Fsrc%2FApp.tsx%3A59%2C36
After
https://codesandbox.io/p/devbox/elegant-turing-r2xd6n?file=%2Fsrc%2FApp.tsx%3A62%2C12&workspaceId=ws_6M5xWXbU7jpjfBKgg78swk