Skip to content

[Toast] Fix Toast.Description not rendering when a custom component is passed #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+62 −2
Open

[Toast] Fix Toast.Description not rendering when a custom component is passed #2977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
106b043
[Toast] Fix Toast.Description not rendering when a custom component i…
sai6855 Oct 14, 2025
41687df
fix prettier
sai6855 Oct 14, 2025
1300ab5
eslint
sai6855 Oct 14, 2025
9a207d7
add test
sai6855 Oct 14, 2025
443f722
apply same fix to ToastTitle
sai6855 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/react/src/toast/description/ToastDescription.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,34 @@ describe('<Toast.Description />', () => {
expect(titleElement).not.to.equal(null);
expect(titleElement.textContent).to.equal('description');
});

it('renders the description when passed to render prop', async () => {
function CustomList() {
Comment on lines +94 to +95
Copy link
Contributor

@atomiks atomiks Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Title component has the same issue

return Toast.useToastManager().toasts.map((toastItem) => (
<Toast.Root key={toastItem.id} toast={toastItem} data-testid="root">
<Toast.Title data-testid="title" />
<Toast.Description
data-testid="description"
render={(props) => <div {...props}>Custom: {props.children}</div>}
/>
</Toast.Root>
));
}

const { user } = await render(
<Toast.Provider>
<Toast.Viewport>
<CustomList />
</Toast.Viewport>
<Button />
</Toast.Provider>,
);

const button = screen.getByRole('button', { name: 'add' });
await user.click(button);

const descriptionElement = screen.getByTestId('description');
expect(descriptionElement).not.to.equal(null);
expect(descriptionElement.textContent).to.equal('Custom: description');
});
});
2 changes: 1 addition & 1 deletion packages/react/src/toast/description/ToastDescription.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const ToastDescription = React.forwardRef(function ToastDescription(

const children = childrenProp ?? toast.description;

const shouldRender = Boolean(children);
const shouldRender = Boolean(children) || render !== undefined;

const id = useId(idProp);

Expand Down
30 changes: 30 additions & 0 deletions packages/react/src/toast/title/ToastTitle.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,34 @@ describe('<Toast.Title />', () => {
expect(titleElement).not.to.equal(null);
expect(titleElement.textContent).to.equal('title');
});

it('renders the title when passed to render prop', async () => {
function CustomList() {
return Toast.useToastManager().toasts.map((toastItem) => (
<Toast.Root key={toastItem.id} toast={toastItem} data-testid="root">
<Toast.Title
data-testid="title"
render={(props) => <div {...props}>Custom: {props.children}</div>}
/>
<Toast.Description data-testid="description" />
</Toast.Root>
));
}

const { user } = await render(
<Toast.Provider>
<Toast.Viewport>
<CustomList />
</Toast.Viewport>
<Button />
</Toast.Provider>,
);

const button = screen.getByRole('button', { name: 'add' });
await user.click(button);

const titleElement = screen.getByTestId('title');
expect(titleElement).not.to.equal(null);
expect(titleElement.textContent).to.equal('Custom: title');
});
});
2 changes: 1 addition & 1 deletion packages/react/src/toast/title/ToastTitle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const ToastTitle = React.forwardRef(function ToastTitle(

const children = childrenProp ?? toast.title;

const shouldRender = Boolean(children);
const shouldRender = Boolean(children) || render !== undefined;

const id = useId(idProp);

Expand Down
Loading