[composite] Avoid skipping missing elements in listRef
#3066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
the
internal
commit: |
Bundle size report
|
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LukasTy
approved these changes
Oct 28, 2025
|
@LukasTy you sure? It happens for me on master Screen.Recording.2025-10-28.at.7.55.59.pm.mov |
|
@atomiks Yes, on Chrome running MacOS 18 it works like this: Screen.Recording.2025-10-28.at.12.50.52.movAlso tested Safari and Firefox... 🤷 |
|
Right, the bug occurs if you focus the input without clicking it, so it doesn't open yet |
Whoops. My bad, I skipped that part. 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak to #2604
Because of virtualization, missing elements in the
listRefarray shouldn't be skipped when determining the active index. In the virtualized demo, pressing ArrowUp lands on the 31st item (last item in the virtual window) instead of the 10,000th item.