chore(iroh, iroh-relay): Avoid a duplicate tungstenite dependency #3006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we used to depend on both tungstenite version 0.21 as well as 0.24, because:
Basically,
tokio-tungstenite-wasmpulls in0.21and there's no newer version of it yet.But we updated all our dependencies including
tungstenite, duplicating it.Notes & open questions
I want this to be temporary until we can finally switch to
fasterwebsocketsentirely once it implementspoll-based methods (but I worry the project's maintenance is ... unclear).I checked the tungstenite changelog, and it doesn't look like there's anything critical in there. The
rustlsupdate doesn't affect us - we don't duplicate rustls versions after this rollback.Change checklist
[ ] Tests if relevant.