Skip to content

Conversation

@matheus23
Copy link
Member

@matheus23 matheus23 commented Dec 4, 2024

Description

Before we used to depend on both tungstenite version 0.21 as well as 0.24, because:

tungstenite v0.21.0
└── tokio-tungstenite v0.21.0
    └── tokio-tungstenite-wasm v0.3.1
        ├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
        └── iroh-relay v0.29.0 (/home/philipp/program/work/iroh/iroh-relay)
            ├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
            └── iroh-net-report v0.29.0 (/home/philipp/program/work/iroh/iroh-net-report)
                └── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
tungstenite v0.24.0
└── tokio-tungstenite v0.24.0
    ├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
    └── iroh-relay v0.29.0 (/home/philipp/program/work/iroh/iroh-relay)
        ├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)
        └── iroh-net-report v0.29.0 (/home/philipp/program/work/iroh/iroh-net-report)
            └── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh)

Basically, tokio-tungstenite-wasm pulls in 0.21 and there's no newer version of it yet.
But we updated all our dependencies including tungstenite, duplicating it.

Notes & open questions

I want this to be temporary until we can finally switch to fasterwebsockets entirely once it implements poll-based methods (but I worry the project's maintenance is ... unclear).

I checked the tungstenite changelog, and it doesn't look like there's anything critical in there. The rustls update doesn't affect us - we don't duplicate rustls versions after this rollback.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • [ ] Tests if relevant.
  • All breaking changes documented.

@matheus23 matheus23 self-assigned this Dec 4, 2024
@github-actions
Copy link

github-actions bot commented Dec 4, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3006/docs/iroh/

Last updated: 2024-12-04T12:31:46Z

@github-actions
Copy link

github-actions bot commented Dec 4, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 2ec98c8

@matheus23 matheus23 added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 566d7eb Dec 4, 2024
27 checks passed
@matheus23 matheus23 deleted the matheus23/avoid-duplicate-tungstenite branch May 15, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants