forked from ontoportal/owlapi_wrapper
-
Notifications
You must be signed in to change notification settings - Fork 9
Fix: Mixed ontology level annotations #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mdorf
merged 54 commits into
ncbo:ontoportal-lirmm/bugfix/ontology-level-annotations
from
ontoportal-lirmm:pr/fix/add-only-master-ontology-annotations
Jun 19, 2025
Merged
Fix: Mixed ontology level annotations #20
mdorf
merged 54 commits into
ncbo:ontoportal-lirmm/bugfix/ontology-level-annotations
from
ontoportal-lirmm:pr/fix/add-only-master-ontology-annotations
Jun 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esolve dependencies when building jar
… graph (like the versionInfo is added) using the omv:URI property
…y work with owl, obo and another one
…etting the imports ontology IRI
…e to pass versionInfo
… and extracting ontologyIRI + all ontology metadata + imports directly from the main ontology in addOntologyIRIAndMetadata (formerly addOntologyIRI)
…wl:imports extraction)
=> « stop using addGroundMetadata (was getting metadata for imports also), and extracting ontologyIRI + all ontology metadata + imports directly from the main ontology in addOntologyIRIAndMetadata (formerly addOntologyIRI) »
=> « fix how we get versionInfo for OBO ontologies »
=> « now adding all ontologies metadata to the output file (even imported ontologies) »
…ncbo_merge_master
…ncbo_merge_master
…ive (Exception in thread "main" java.lang.NoClassDefFoundError: javax/xml/bind/annotation/adapters/HexBinaryAdapter)
Author
|
Some notes:
|
1 task
e0ad8c7 to
168cb9b
Compare
add guard to avoid .get() of absent value
* Add IRIMapper for SKOS Core Vocabulary Resolves #22 * Update developer details * Fix insecure link warning * Remove defunct support list archive * Bump commons-csv from 1.9.0 to 1.10.0 * Bump logback-classic from 1.2.11 to 1.4.11 * Update developer and contributor details * [maven-release-plugin] prepare release owlapi-wrapper-1.4.2 * [maven-release-plugin] prepare for next development iteration * [maven-release-plugin] rollback the release of owlapi-wrapper-1.4.2 * [maven-release-plugin] prepare release v1.4.2 * [maven-release-plugin] prepare for next development iteration
…ontology Fix: move sub.get() after the check to prevent expection
…vel-annotation-imports
…only-master-ontology-annotations
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
============================================
+ Coverage 72.98% 73.05% +0.06%
- Complexity 165 167 +2
============================================
Files 15 15
Lines 733 746 +13
Branches 116 117 +1
============================================
+ Hits 535 545 +10
- Misses 152 153 +1
- Partials 46 48 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
72117fa
into
ncbo:ontoportal-lirmm/bugfix/ontology-level-annotations
1 check passed
mdorf
added a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix #18
Changes
addAnnoations(masterOntology)(e0ad8c7)Example
CNO (source)
Generated xrdf CNO