fix(richdocuments): Use filename from DownloadAs postmessage for correct file extension#16623
Open
Rash419 wants to merge 2 commits intonextcloud:masterfrom
Open
fix(richdocuments): Use filename from DownloadAs postmessage for correct file extension#16623Rash419 wants to merge 2 commits intonextcloud:masterfrom
Rash419 wants to merge 2 commits intonextcloud:masterfrom
Conversation
…ect file extension Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
alperozturk96
requested changes
Mar 4, 2026
|
|
||
| else -> { | ||
| val downloadFileName = downloadJson.optString(FILENAME, fileName) | ||
| downloadFile(url, downloadFileName) |
Collaborator
There was a problem hiding this comment.
Hi, thank you for the PR.
I have a quick question regarding the fileName handling. Is the fileName always incorrect, or is it only missing the extension in some cases? Also, can we confirm whether downloadJson.optString(FILENAME, fileName) consistently returns valid data?
Could you please share the steps to reproduce the issue and how you tested this? That would help us better understand the scenario and verify the behavior on our side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
🏁 Checklist