Skip to content

fix(richdocuments): Use filename from DownloadAs postmessage for correct file extension #16623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rash419 wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −1
Open

fix(richdocuments): Use filename from DownloadAs postmessage for correct file extension #16623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
513ef26
fix(richdocuments): Use filename from DownloadAs postmessage for corr…
Rash419 Mar 3, 2026
18b0381
Merge branch 'master' into fix-downlaod-as
Rash419 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/main/java/com/owncloud/android/ui/activity/RichDocumentsEditorWebView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,13 @@ class RichDocumentsEditorWebView : EditorWebView() {
val url = downloadJson.getString(URL).toUri()
when (downloadJson.getString(TYPE)) {
PRINT -> printFile(url)

SLIDESHOW -> showSlideShow(url)
else -> downloadFile(url, fileName)

else -> {
val downloadFileName = downloadJson.optString(FILENAME, fileName)
downloadFile(url, downloadFileName)
Copy link
Collaborator

@alperozturk96 alperozturk96 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the PR.

I have a quick question regarding the fileName handling. Is the fileName always incorrect, or is it only missing the extension in some cases? Also, can we confirm whether downloadJson.optString(FILENAME, fileName) consistently returns valid data?

Could you please share the steps to reproduce the issue and how you tested this? That would help us better understand the scenario and verify the behavior on our side.

Copy link
Author

@Rash419 Rash419 Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

fileName extension is incorrect when using "Download as" button to download file into different format. In Collabora Online side, I added CollaboraOnline/online#14344 filename property to the DownloadAs postmessage JSON which will filename with correct extension.

Steps to reproduce:

  1. Open writer document
  2. Hamburger Menu > Download as -> rtf
  3. File will have wrong extension on download

}
}
} catch (e: JSONException) {
Log_OC.e(this, "Failed to parse download json message: $e")
Expand Down Expand Up @@ -219,5 +224,6 @@ class RichDocumentsEditorWebView : EditorWebView() {
private const val PRINT = "print"
private const val SLIDESHOW = "slideshow"
private const val NEW_NAME = "NewName"
private const val FILENAME = "filename"
}
}