fix(reference): Respect IReferenceProvider::getCacheTTL() in ReferenceManager #56013
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexioJ
requested review from
Altahrim,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
LexioJ
force-pushed
the
fix/reference-manager-respect-cache-ttl
branch
from
7fff926 to
1b5584d
Compare
…eManager The ReferenceManager was ignoring the getCacheTTL() method defined in the IReferenceProvider interface and always using the hardcoded 3600 second TTL. This change respects the provider's custom cache TTL with a fallback to the default CACHE_TTL constant, allowing providers to specify shorter TTLs for frequently-changing data such as external API integrations. Fixes nextcloud#56012 Signed-off-by: Alexander Askin <lexioj@gmail.com>
LexioJ
force-pushed
the
fix/reference-manager-respect-cache-ttl
branch
from
1b5584d to
8a95c7b
Compare
|
Thank you for the pull request! Please open a feature request if you need such a method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR fix?
Fixes #56012
Changes
The ReferenceManager was ignoring the
getCacheTTL()method defined in the IReferenceProvider interface and always using the hardcoded 3600 second TTL.This change respects the provider's custom cache TTL with a fallback to the default CACHE_TTL constant, allowing providers to specify shorter TTLs for frequently-changing data such as external API integrations.
Implementation
getCacheTTL()on the matched providerself::CACHE_TTLBackward Compatibility
✅ Fully backward compatible:
getCacheTTL()will get the default 3600s TTL