Skip to content

fix(reference): Respect IReferenceProvider::getCacheTTL() in ReferenceManager #56013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(reference): Respect IReferenceProvider::getCacheTTL() in ReferenceManager #56013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/private/Collaboration/Reference/ReferenceManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,14 @@ public function resolveReference(string $referenceId, bool $public = false, $sha
}
if ($reference) {
$cachePrefix = $matchedProvider->getCachePrefix($referenceId);
// Respect provider's custom cache TTL, fallback to default if not specified
$cacheTtl = method_exists($matchedProvider, 'getCacheTTL') ? $matchedProvider->getCacheTTL() : self::CACHE_TTL;
$cacheTtl = $cacheTtl ?? self::CACHE_TTL;
if ($cachePrefix !== '') {
// If a prefix is used we set an additional key to know when we need to delete by prefix during invalidateCache()
$this->cache->set('hasPrefix-' . md5($cachePrefix), true, self::CACHE_TTL);
$this->cache->set('hasPrefix-' . md5($cachePrefix), true, $cacheTtl);
}
$this->cache->set($cacheKey, Reference::toCache($reference), self::CACHE_TTL);
$this->cache->set($cacheKey, Reference::toCache($reference), $cacheTtl);
return $reference;
}

Expand Down