-
Notifications
You must be signed in to change notification settings - Fork 936
Vembrane filter #9340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Vembrane filter #9340
Conversation
|
Hi @famosab, This PR is originates from PR #9290, which was done using a company git account. The new PR #9340 is now from a personal account. All previous comments can be viewed in this URL. In this PR, I have added the following changes:
Please let me know if there are more changes to be made for this PR to be merge-able :) ! Cheers, |
famosab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already!
98c1c72 to
fcadf1b
Compare
famosab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise - very nice work 🚀
fcadf1b to
6ac59f8
Compare
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda