Add a happy path for normalizeString() #60463
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irengrig
commented
Oct 28, 2025
irengrig
commented
- for the case when we can just return the original value, maybe correcting the path separators
- for the case when we can just return the original value, maybe correcting the path separators
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
ChALkeR
reviewed
Oct 28, 2025
Comment on lines
+96
to
+97
| const otherSeparator = separator === CHAR_FORWARD_SLASH ? CHAR_BACKWARD_SLASH : CHAR_FORWARD_SLASH; | ||
| return path.replaceAll(otherSeparator, separator); |
Member
There was a problem hiding this comment.
This will fail on the following case:
> path.normalize('a\\d')
'a\\d'
> path.posix.normalize('a\\d')
'a\\d'This code misses that isPathSeparator is an argument and could be isPosixPathSeparator.
himself65
reviewed
Oct 28, 2025
Member
himself65
left a comment
himself65
left a comment
There was a problem hiding this comment.
Should the title be the pref: ...
And can you run the benchmark to see the performance improvement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.