Skip to content

Add a happy path for normalizeString() #60463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Add a happy path for normalizeString() #60463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ function isWindowsDeviceRoot(code) {

// Resolves . and .. elements in a path with directory names
function normalizeString(path, allowAboveRoot, separator, isPathSeparator) {
if (!path.includes(`${CHAR_DOT}${CHAR_FORWARD_SLASH}` &&
!path.includes(`${CHAR_DOT}${CHAR_BACKWARD_SLASH}`) {
// Happy path: no . and .. elements - avoid string concatenation in cycle
const otherSeparator = separator === CHAR_FORWARD_SLASH ? CHAR_BACKWARD_SLASH : CHAR_FORWARD_SLASH;
return path.replaceAll(otherSeparator, separator);
Comment on lines +96 to +97
Copy link
Member

@ChALkeR ChALkeR Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail on the following case:

> path.normalize('a\\d')
'a\\d'
> path.posix.normalize('a\\d')
'a\\d'

This code misses that isPathSeparator is an argument and could be isPosixPathSeparator.

}
let res = '';
let lastSegmentLength = 0;
let lastSlash = -1;
Expand Down