Skip to content

Comments

Clarify PR scope: documentation audit + DetailTabTable implementation#1062

Merged
karilint merged 1 commit intocodex/create-feature-implementation-plan-and-task-breakdownfrom
copilot/sub-pr-1061
Feb 18, 2026
Merged

Clarify PR scope: documentation audit + DetailTabTable implementation#1062
karilint merged 1 commit intocodex/create-feature-implementation-plan-and-task-breakdownfrom
copilot/sub-pr-1061

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

The original PR description focused on documentation audit but omitted substantial implementation work. This update clarifies the full scope.

Changes

Documentation

  • Added audit baseline and matrix in documentation/frontend/tables.md inventorying detail-tab table/list implementations across Locality, Species, Reference, TimeUnit, TimeBound, and Museum components
  • Documented primitive types (SimpleTable, EditableTable, SelectingTable), data sources (API-driven, context-driven, mixed), and edit-mode actions for 10 user-requested URLs
  • Added rollout checklist for future tab migrations to DetailTabTable

Shared Component

  • Created DetailTabTable wrapper consolidating column sorting, shift-click multi-sort, per-column filters, column visibility toggle, and CSV export
  • Applied default species ordering (order_name, family_name, genus_name, species_name) when no explicit sort is set
  • Migrated 8 read-only and editable tabs to use unified table controls

Backend

  • Added tabularQuery.ts service validating sorting and pagination parameters
  • Implemented query validation for museum, reference, timeUnit, timeBound tab-list endpoints
  • Added API tests for query validation and pagination edge cases

Edit Controls

  • Enabled advanced table controls (sort, filter, export) in EditableTable and SelectingTable
  • CSV export respects current sorted/filtered/visible state

Example

Before migration, tabs used inconsistent primitives with limited interaction:

// Reference/Tabs/LocalityTab.tsx - old
<SimpleTable {...} /> // No sorting, filtering, or export

After migration:

// Reference/Tabs/LocalityTab.tsx - new
<DetailTabTable
  columns={columns}
  data={localities}
  tableId="reference-localities-tab"
  onRowClick={handleRowClick}
/>
// Gains: sortable columns, filters, column visibility, CSV export

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Feb 18, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkpoint.prisma.io
    • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node /home/REDACTED/work/nowdatabase/nowdatabase/backend/node_modules/prisma/build/child {&#34;product&#34;:&#34;prisma&#34;,&#34;version&#34;:&#34;5.22.0&#34;,&#34;cli_install_type&#34;:&#34;local&#34;,&#34;information&#34;:&#34;&#34;,&#34;local_timestamp&#34;:&#34;2026-02-18T14:14:32Z&#34;,&#34;project_hash&#34;:&#34;a620d0a8&#34;,&#34;cli_path&#34;:&#34;/home/REDACTED/work/nowdatabase/nowdatabase/backend/node_modules/prisma/build/index.js&#34;,&#34;cli_pa (dns block)
  • download.cypress.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node index.js --exec install x.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Audit detail-tab table and list implementations Clarify PR scope: documentation audit + DetailTabTable implementation Feb 18, 2026
Copilot AI requested a review from karilint February 18, 2026 14:19
@karilint karilint marked this pull request as ready for review February 18, 2026 14:45
@karilint karilint merged commit 25b66bd into codex/create-feature-implementation-plan-and-task-breakdown Feb 18, 2026
1 check passed
@karilint karilint deleted the copilot/sub-pr-1061 branch February 18, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants