refactor(auth): use provider endpoint directly instead of campus oauth proxy#14
Merged
refactor(auth): use provider endpoint directly instead of campus oauth proxy#14
Conversation
…h proxy - Use app's own callback URL as redirect_uri instead of proxy callback - Use /auth/v1/authorize provider endpoint directly instead of /campus/authorize proxy - Remove unnecessary target parameter from authorization URL The campus oauth proxy pattern doesn't make sense for cross-domain deployments since the provider's /authorize endpoint handles the flow and redirects directly to the app's callback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redirect_uriinstead of proxy callback/auth/v1/authorizeprovider endpoint directly instead of/campus/authorizeproxytargetparameter from authorization URLBackground
The campus oauth proxy pattern doesn't make sense for cross-domain deployments. The provider's
/authorizeendpoint handles the OAuth flow and redirects directly to the app's callback, making the proxy layer unnecessary.This aligns with nyjc-computing/campus#414 which removes the campus oauth proxy.
Changes
AuthRoot.authorize(): Usetargetdirectly asredirect_uriauthorizeinstead ofcampus/authorizetargetquery parameter from authorization URLCo-Authored-By: Claude Opus 4.6 noreply@anthropic.com