[IMP] account: change group payments memo to pay/xxxx #4856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Nov 5, 2025
| 'use_date_range': True, | ||
| 'company_id': self.id, | ||
| 'prefix': 'BATCH/%(year)s/', | ||
| 'prefix': 'PAY/%(year)s/', |
There was a problem hiding this comment.
This change is good but i think that if runbot was working like a normal pr, you would have a lot of test failing 👀 Take a look at addons/account/tests/test_account_payment_register.py 😄 Run the tests and check the ones that fails and fix them 😄
vicire1
force-pushed
the
18.0-change-memo-to-pay-videc
branch
from
d7790f1 to
285f61e
Compare
vicire1
changed the title
vicire1
force-pushed
the
18.0-change-memo-to-pay-videc
branch
from
285f61e to
3d77bdc
Compare
vicire1
changed the title
When making group payments a payment memo is generated with BATCH prefix but it can be confsing as there is a batch payment feature so I changed the prefix to PAY and the tests also accordingly task-5231324
vicire1
force-pushed
the
18.0-change-memo-to-pay-videc
branch
from
3d77bdc to
3caafe9
Compare
vicire1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making group payments a payment memo is generated with BATCH prefix but it can be confusing as there is a batch payment feature so I changed the prefix to PAY and the tests also accordingly
task-5231324