Skip to content

[IMP] account: change group payments memo to pay/xxxx #4856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0-rd-accounting-onboarding-malb
Choose a base branch
from
Open

[IMP] account: change group payments memo to pay/xxxx #4856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/account/models/company.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class ResCompany(models.Model):
'padding': 5,
'use_date_range': True,
'company_id': self.id,
'prefix': 'BATCH/%(year)s/',
'prefix': 'PAY/%(year)s/',
Copy link

@malb-odoo malb-odoo Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good but i think that if runbot was working like a normal pr, you would have a lot of test failing 👀 Take a look at addons/account/tests/test_account_payment_register.py 😄 Run the tests and check the ones that fails and fix them 😄

}),
)

Expand Down
8 changes: 4 additions & 4 deletions addons/account/tests/test_account_payment_register.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ def test_register_payment_single_batch_grouped_keep_open_lower_amount(self):
})._create_payments()

self.assertRecordValues(payments, [{
'memo': Like(f'BATCH/{self.current_year}/...'),
'memo': Like(f'PAY/{self.current_year}/...'),
'payment_method_line_id': self.inbound_payment_method_line.id,
}])
self.assertRecordValues(payments.move_id.line_ids.sorted('balance'), [
Expand Down Expand Up @@ -237,7 +237,7 @@ def test_register_payment_single_batch_grouped_keep_open_higher_amount(self):
})._create_payments()

self.assertRecordValues(payments, [{
'memo': Like(f'BATCH/{self.current_year}/...'),
'memo': Like(f'PAY/{self.current_year}/...'),
'payment_method_line_id': self.inbound_payment_method_line.id,
}])
self.assertRecordValues(payments.move_id.line_ids.sorted('balance'), [
Expand Down Expand Up @@ -272,7 +272,7 @@ def test_register_payment_single_batch_grouped_writeoff_lower_amount_debit(self)
})._create_payments()

self.assertRecordValues(payments, [{
'memo': Like(f'BATCH/{self.current_year}/...'),
'memo': Like(f'PAY/{self.current_year}/...'),
'payment_method_line_id': self.inbound_payment_method_line.id,
}])
self.assertRecordValues(payments.move_id.line_ids.sorted('balance'), [
Expand Down Expand Up @@ -315,7 +315,7 @@ def test_register_payment_single_batch_grouped_writeoff_higher_amount_debit(self
})._create_payments()

self.assertRecordValues(payments, [{
'memo': Like(f'BATCH/{self.current_year}/...'),
'memo': Like(f'PAY/{self.current_year}/...'),
'payment_method_line_id': self.inbound_payment_method_line.id,
}])
self.assertRecordValues(payments.move_id.line_ids.sorted('balance'), [
Expand Down