OBPIH-6956 Add tests for assert qty and split line with 0 qty #50
Merged
awalkowiak merged 4 commits intomainfrom Mar 11, 2025
Merged
OBPIH-6956 Add tests for assert qty and split line with 0 qty #50awalkowiak merged 4 commits intomainfrom
awalkowiak merged 4 commits intomainfrom
Conversation
awalkowiak
reviewed
Feb 26, 2025
|
|
||
| get clearProductSelect() { | ||
| return this.row.locator( | ||
| '[class="css-16pqwjk-indicatorContainer react-select__indicator react-select__clear-indicator"]' |
Contributor
There was a problem hiding this comment.
Are you sure this css class is constant? Let's double check that this 16pqwjk is not changing.
| import { StockMovementResponse } from '@/types'; | ||
| import { formatDate, getDateByOffset } from '@/utils/DateUtils'; | ||
|
|
||
| test.describe('Assert qty inputs when split lines', () => { |
Contributor
There was a problem hiding this comment.
What are you "asserting" here?
Contributor
There was a problem hiding this comment.
Plus maybe it would be better to use full quantity instead qty in these descriptions
| receivingPage.receivingStep.table.row(5).receivingNowField.textbox | ||
| ).toHaveValue('100'); | ||
| await expect( | ||
| receivingPage.receivingStep.table.getCellValue(2, 'Lot/Serial No.') |
Contributor
There was a problem hiding this comment.
Can you move this to some constant?
| receivingPage.receivingStep.table.getCellValue(2, 'Lot/Serial No.') | ||
| ).toContainText(lot); | ||
| await expect( | ||
| receivingPage.receivingStep.table.getCellValue(2, 'Expiration date') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for assert qty inputs when split lines, edit original qty to 0 and to edit original line to another item.