Skip to content

OBPIH-6956 Add tests for assert qty and split line with 0 qty #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awalkowiak merged 4 commits into from
Mar 11, 2025
Merged

OBPIH-6956 Add tests for assert qty and split line with 0 qty #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea9c70d
OBPIH-6956 add elements to edit modal
kkrawczyk123 Feb 21, 2025
06bc3fc
OBPIH-6956 add elements to check step
kkrawczyk123 Feb 21, 2025
3882d59
OBPIH-6956 add tests for assert qty and split line with 0 qty
kkrawczyk123 Feb 21, 2025
4a0a994
OBPIH-6956 improve naming and update locator
kkrawczyk123 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/pages/receiving/components/EditModalTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,22 @@ class Row extends BasePageModel {
this.expiryDatePickerField = new DatePicker(page, 'Expiry', row);
this.quantityShippedField = new TextField(page, 'Quantity shipped', row);
}

get clearProductSelect() {
return this.row.locator('.react-select__clear-indicator');
}

async getProductSelect(name: string) {
await this.row
.getByTestId('custom-select-element')
.getByRole('textbox')
.fill(name);
await this.page
.getByTestId('custom-select-dropdown-menu')
.locator('.react-select__option')
.nth(0)
.click();
}
}

export default EditModalTable;
4 changes: 4 additions & 0 deletions src/pages/receiving/steps/CheckStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ class CheckStep extends BasePageModel {
.locator('.s-alert-box-inner')
.getByText('Must occur on or after Actual Shipping Date');
}

get backToEditButton() {
return this.page.getByRole('button', { name: 'Back to edit' });
}
}

export default CheckStep;
276 changes: 276 additions & 0 deletions src/tests/receiving/assertQtyInputs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,276 @@
import { ShipmentType } from '@/constants/ShipmentType';
import { expect, test } from '@/fixtures/fixtures';
import { StockMovementResponse } from '@/types';
import { formatDate, getDateByOffset } from '@/utils/DateUtils';

test.describe('Assert if quantity inputs remain when split lines', () => {
let STOCK_MOVEMENT: StockMovementResponse;

test.beforeEach(
async ({
supplierLocationService,
stockMovementService,
mainProductService,
otherProductService,
thirdProductService,
}) => {
const supplierLocation = await supplierLocationService.getLocation();
const PRODUCT_ONE = await mainProductService.getProduct();
const PRODUCT_TWO = await otherProductService.getProduct();
const PRODUCT_THREE = await thirdProductService.getProduct();

STOCK_MOVEMENT = await stockMovementService.createInbound({
originId: supplierLocation.id,
});

await stockMovementService.addItemsToInboundStockMovement(
STOCK_MOVEMENT.id,
[
{
productId: PRODUCT_ONE.id,
quantity: 50,
},
{ productId: PRODUCT_TWO.id, quantity: 100 },
{ productId: PRODUCT_THREE.id, quantity: 200 },
]
);

await stockMovementService.sendInboundStockMovement(STOCK_MOVEMENT.id, {
shipmentType: ShipmentType.AIR,
});
}
);

test.afterEach(async ({ stockMovementShowPage, stockMovementService }) => {
await stockMovementShowPage.goToPage(STOCK_MOVEMENT.id);
const isRollbackLastReceiptButtonVisible =
await stockMovementShowPage.rollbackLastReceiptButton.isVisible();
const isRollbackButtonVisible =
await stockMovementShowPage.rollbackButton.isVisible();

// due to failed test, shipment might not be received which will not show the button
if (isRollbackLastReceiptButtonVisible) {
await stockMovementShowPage.rollbackLastReceiptButton.click();
}

if (isRollbackButtonVisible) {
await stockMovementShowPage.rollbackButton.click();
}

await stockMovementService.deleteStockMovement(STOCK_MOVEMENT.id);
});

test('Assert quantity input after split line', async ({
stockMovementShowPage,
receivingPage,
}) => {
const lot = 'add-lot-test';
const expDate = getDateByOffset(new Date(), 5);

await test.step('Go to stock movement show page', async () => {
await stockMovementShowPage.goToPage(STOCK_MOVEMENT.id);
await stockMovementShowPage.isLoaded();
});

await test.step('Go to shipment receiving page', async () => {
await stockMovementShowPage.receiveButton.click();
await receivingPage.receivingStep.isLoaded();
});

await test.step('Autofill receiving quantity', async () => {
await receivingPage.receivingStep.isLoaded();
await receivingPage.receivingStep.autofillQuantitiesButton.click();
});

await test.step('Open edit modal for item and split line', async () => {
await receivingPage.receivingStep.table.row(2).editButton.click();
await receivingPage.receivingStep.editModal.isLoaded();
await receivingPage.receivingStep.editModal.addLineButton.click();
await receivingPage.receivingStep.editModal.table
.row(0)
.quantityShippedField.numberbox.fill('100');
await receivingPage.receivingStep.editModal.table
.row(0)
.lotNumberField.textbox.fill(lot);
await receivingPage.receivingStep.editModal.table
.row(0)
.expiryDatePickerField.fill(expDate);
await receivingPage.receivingStep.editModal.table
.row(1)
.quantityShippedField.numberbox.fill('50');
await receivingPage.receivingStep.editModal.addLineButton.click();
await receivingPage.receivingStep.editModal.table
.row(2)
.quantityShippedField.numberbox.fill('50');
await receivingPage.receivingStep.editModal.saveButton.click();
await receivingPage.receivingStep.isLoaded();
});

await test.step('Assert quantity input before split line', async () => {
await expect(
receivingPage.receivingStep.table.row(1).receivingNowField.textbox
).toHaveValue('50');
await expect(
receivingPage.receivingStep.table.row(2).receivingNowField.textbox
).toBeEmpty();
await expect(
receivingPage.receivingStep.table.row(3).receivingNowField.textbox
).toBeEmpty();
await expect(
receivingPage.receivingStep.table.row(4).receivingNowField.textbox
).toBeEmpty();
await expect(
receivingPage.receivingStep.table.row(5).receivingNowField.textbox
).toHaveValue('100');
await expect(
receivingPage.receivingStep.table.getCellValue(2, 'Lot/Serial No.')
Copy link
Contributor

@awalkowiak awalkowiak Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to some constant?

).toContainText(lot);
await expect(
receivingPage.receivingStep.table.getCellValue(2, 'Expiration date')
Copy link
Contributor

@awalkowiak awalkowiak Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

).toContainText(formatDate(expDate, 'MM/DD/YYYY'));
});

await test.step('Autofill quantity after split line', async () => {
await receivingPage.receivingStep.isLoaded();
await receivingPage.receivingStep.autofillQuantitiesButton.click();
await expect(
receivingPage.receivingStep.table.row(2).receivingNowField.textbox
).toHaveValue('100');
await expect(
receivingPage.receivingStep.table.row(3).receivingNowField.textbox
).toHaveValue('50');
await expect(
receivingPage.receivingStep.table.row(4).receivingNowField.textbox
).toHaveValue('50');
});

await test.step('Edit another line', async () => {
await receivingPage.receivingStep.table.row(5).editButton.click();
await receivingPage.receivingStep.editModal.isLoaded();
await receivingPage.receivingStep.editModal.table
.row(0)
.lotNumberField.textbox.fill(lot);
await receivingPage.receivingStep.editModal.table
.row(0)
.expiryDatePickerField.fill(expDate);
await receivingPage.receivingStep.editModal.saveButton.click();
await receivingPage.receivingStep.isLoaded();
await expect(
receivingPage.receivingStep.table.row(1).receivingNowField.textbox
).toHaveValue('50');
await expect(
receivingPage.receivingStep.table.row(2).receivingNowField.textbox
).toHaveValue('100');
await expect(
receivingPage.receivingStep.table.row(3).receivingNowField.textbox
).toHaveValue('50');
await expect(
receivingPage.receivingStep.table.row(4).receivingNowField.textbox
).toHaveValue('50');
await expect(
receivingPage.receivingStep.table.row(5).receivingNowField.textbox
).toBeEmpty();
await expect(
receivingPage.receivingStep.table.getCellValue(5, 'Lot/Serial No.')
).toContainText(lot);
await expect(
receivingPage.receivingStep.table.getCellValue(5, 'Expiration date')
).toContainText(formatDate(expDate, 'MM/DD/YYYY'));
});
});

test('Assert quantity input after split line whe use save and exit', async ({
stockMovementShowPage,
receivingPage,
}) => {
const lot = 'add-lot-test';
const expDate = getDateByOffset(new Date(), 5);

await test.step('Go to stock movement show page', async () => {
await stockMovementShowPage.goToPage(STOCK_MOVEMENT.id);
await stockMovementShowPage.isLoaded();
});

await test.step('Go to shipment receiving page', async () => {
await stockMovementShowPage.receiveButton.click();
await receivingPage.receivingStep.isLoaded();
});

await test.step('Autofill quantity for items', async () => {
await receivingPage.receivingStep.isLoaded();
await receivingPage.receivingStep.table
.row(2)
.receivingNowField.textbox.fill('200');
await receivingPage.receivingStep.table
.row(3)
.receivingNowField.textbox.fill('100');
await receivingPage.receivingStep.saveAndExitButton.click();
});

await test.step('Return to receipt', async () => {
await stockMovementShowPage.receiveButton.click();
await receivingPage.receivingStep.isLoaded();
await expect(
receivingPage.receivingStep.table.row(1).receivingNowField.textbox
).toBeEmpty();
await expect(
receivingPage.receivingStep.table.row(2).receivingNowField.textbox
).toHaveValue('200');
await expect(
receivingPage.receivingStep.table.row(3).receivingNowField.textbox
).toHaveValue('100');
});

await test.step('Open edit modal for item without quantity input', async () => {
await receivingPage.receivingStep.table.row(1).editButton.click();
await receivingPage.receivingStep.editModal.isLoaded();
await receivingPage.receivingStep.editModal.addLineButton.click();
await receivingPage.receivingStep.editModal.table
.row(0)
.quantityShippedField.numberbox.fill('25');
await receivingPage.receivingStep.editModal.table
.row(0)
.lotNumberField.textbox.fill(lot);
await receivingPage.receivingStep.editModal.table
.row(0)
.expiryDatePickerField.fill(expDate);
await receivingPage.receivingStep.editModal.table
.row(1)
.quantityShippedField.numberbox.fill('25');
await receivingPage.receivingStep.editModal.saveButton.click();
await receivingPage.receivingStep.isLoaded();
});

await test.step('Assert quantity input after split line', async () => {
await expect(
receivingPage.receivingStep.table.row(1).receivingNowField.textbox
).toBeEmpty();
await expect(
receivingPage.receivingStep.table.row(2).receivingNowField.textbox
).toBeEmpty();
await expect(
receivingPage.receivingStep.table.row(3).receivingNowField.textbox
).toHaveValue('200');
await expect(
receivingPage.receivingStep.table.row(4).receivingNowField.textbox
).toHaveValue('100');
await expect(
receivingPage.receivingStep.table.getCellValue(1, 'Lot/Serial No.')
).toContainText(lot);
await expect(
receivingPage.receivingStep.table.getCellValue(1, 'Expiration date')
).toContainText(formatDate(expDate, 'MM/DD/YYYY'));
});

await test.step('Autofill quantity after split line', async () => {
await receivingPage.receivingStep.isLoaded();
await receivingPage.receivingStep.autofillQuantitiesButton.click();
await expect(
receivingPage.receivingStep.table.row(1).receivingNowField.textbox
).toHaveValue('25');
await expect(
receivingPage.receivingStep.table.row(2).receivingNowField.textbox
).toHaveValue('25');
});
});
});
Loading
Loading