Skip to content

8376185: NoSuchFieldError thrown after a record with type annotation retransformed#145

Closed
jpbempel wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-jpbempel-0c60c9ca-master
Closed

8376185: NoSuchFieldError thrown after a record with type annotation retransformed#145
jpbempel wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-jpbempel-0c60c9ca-master

Conversation

@jpbempel
Copy link
Copy Markdown
Member

@jpbempel jpbempel commented Apr 1, 2026

Hi all,

This pull request contains a backport of commit 0c60c9ca from the openjdk/jdk repository.

The commit being backported was authored by Jean-Philippe Bempel on 25 Mar 2026 and was reviewed by Serguei Spitsyn and David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8376185 needs maintainer approval

Issue

  • JDK-8376185: NoSuchFieldError thrown after a record with type annotation retransformed (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk26u.git pull/145/head:pull/145
$ git checkout pull/145

Update a local copy of the PR:
$ git checkout pull/145
$ git pull https://git.openjdk.org/jdk26u.git pull/145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 145

View PR using the GUI difftool:
$ git pr show -t 145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk26u/pull/145.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 1, 2026

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8376185: NoSuchFieldError thrown after a record with type annotation retransformed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 0c60c9ca1477a114a9c7095226d3a1e5d31600fb 8376185: NoSuchFieldError thrown after a record with type annotation retransformed Apr 1, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 1, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

⚠️ @jpbempel This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2026
@jpbempel
Copy link
Copy Markdown
Member Author

jpbempel commented Apr 1, 2026

/approval request retransformation on a record with type annotation on a record component leads to a corrupted state in the JVM memory. Best cases we have an exception, worst cases a JVM crash. It is common to use type annotation like @NotNull on the record components.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@jpbempel
8376185: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Apr 1, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 1, 2026

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 7, 2026
@jpbempel
Copy link
Copy Markdown
Member Author

jpbempel commented Apr 7, 2026

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 7, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 7, 2026

@jpbempel
Your change (at version fa2d473) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 14, 2026

Going to push as commit 0844731.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 14, 2026
@openjdk openjdk bot closed this Apr 14, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 14, 2026

@phohensee @jpbempel Pushed as commit 0844731.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants