Conversation
Adding it here as it has dependencies to several use cases projects
Vignaudo
reviewed
Jan 10, 2025
| @@ -1,2 +1,3 @@ | |||
| requests | |||
| elasticsearch==8.17.0 | |||
| pandas | |||
Contributor
There was a problem hiding this comment.
I don't think python-sdk require this dependencies
Contributor
Author
There was a problem hiding this comment.
Hi @Vignaudo ,
cc @abr-ubiqube
There was a suggestion to add pandas in python-sdk project in order to have always pandas installed by default in MSA for several repo projects, so without dealing with specific project lib requirement
So if you think we should not go this way, then we can close this PR
Thanks
Contributor
There was a problem hiding this comment.
Yes,
Common good practice is to keep dependency at minimal, and an unused dependency in a project have lot of chance to disapear. So yes add this dependency where it is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding it here as it has dependencies to several use cases projects