Skip to content

adding pandas lib #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Diyal976 wants to merge 1 commit into from
Closed

adding pandas lib #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
requests
elasticsearch==8.17.0
pandas
Copy link
Contributor

@Vignaudo Vignaudo Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think python-sdk require this dependencies

Copy link
Contributor Author

@Diyal976 Diyal976 Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vignaudo ,
cc @abr-ubiqube

There was a suggestion to add pandas in python-sdk project in order to have always pandas installed by default in MSA for several repo projects, so without dealing with specific project lib requirement

So if you think we should not go this way, then we can close this PR

Thanks

Copy link
Contributor

@Vignaudo Vignaudo Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,
Common good practice is to keep dependency at minimal, and an unused dependency in a project have lot of chance to disapear. So yes add this dependency where it is needed.