Removed com.carrotsearch.randomizedtesting.RandomizedRunner from tests in src/integrationTest#5869
Merged
cwperks merged 6 commits intoopensearch-project:mainfrom Dec 24, 2025
Conversation
…grationTest Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
nibix
requested review from
DarshitChanpura,
RyanL1997,
cwperks,
derek-ho,
reta,
shikharj05 and
willyborankin
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5869 +/- ##
==========================================
+ Coverage 73.68% 73.73% +0.04%
==========================================
Files 438 438
Lines 26644 26649 +5
Branches 3938 3939 +1
==========================================
+ Hits 19633 19649 +16
+ Misses 5138 5128 -10
+ Partials 1873 1872 -1 🚀 New features to boost your workflow:
|
1 task
Collaborator
Author
|
@cwperks @DarshitChanpura @shikharj05 what do you think about this? This would fix the test issues in #5865 |
cwperks
reviewed
Dec 23, 2025
src/integrationTest/java/org/opensearch/security/api/InternalUsersRestApiIntegrationTest.java
Show resolved
Hide resolved
cwperks
approved these changes
Dec 23, 2025
RyanL1997
approved these changes
Dec 24, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is in reaction to the issues observed in #5865 (comment)
This PR removes the com.carrotsearch.randomizedtesting.RandomizedRunner test runner from the tests in src/integrationTest/ ; IMHO, this randomized testing approach is not really applicable to security plugin testing anyway.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.