New tests for protected indices feature#5865
Merged
shikharj05 merged 2 commits intoopensearch-project:mainfrom Jan 7, 2026
Merged
New tests for protected indices feature#5865shikharj05 merged 2 commits intoopensearch-project:mainfrom
shikharj05 merged 2 commits intoopensearch-project:mainfrom
Conversation
nibix
requested review from
DarshitChanpura,
RyanL1997,
cwperks,
derek-ho,
reta,
shikharj05 and
willyborankin
as code owners
Collaborator
Author
|
Suddenly these tests started failing, without having touched them. So far I am clueless why this is happening. |
Member
|
Taking a look at the tests |
Member
|
@nibix are the test failures only showing on Github? I was not able to reproduce on my mac, but will also try on linux to see if its reproducible there |
Collaborator
Author
|
I could not reproduce it locally, so far. This is mysterious indeed. |
Merged
1 task
nibix
force-pushed
the
protected-index-tests
branch
from
1dd9fbe to
7c01bad
Compare
Collaborator
Author
|
Merging #5869 first would fix the tests. I am still clueless regarding any other ways to fix the tests. |
nibix
force-pushed
the
protected-index-tests
branch
from
7c01bad to
93ea822
Compare
Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
nibix
force-pushed
the
protected-index-tests
branch
from
93ea822 to
962af3a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5865 +/- ##
==========================================
+ Coverage 73.68% 73.72% +0.04%
==========================================
Files 438 438
Lines 26649 26649
Branches 3939 3939
==========================================
+ Hits 19635 19646 +11
+ Misses 5141 5128 -13
- Partials 1873 1875 +2 🚀 New features to boost your workflow:
|
…currency issue Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
nibix
force-pushed
the
protected-index-tests
branch
from
895748b to
76ea28b
Compare
Collaborator
Author
|
@cwperks @DarshitChanpura @shikharj05 I could now resolve the issues with this test PR. It contains now an additional commit to fix issues with concurrent test execution. Would you be available to review this? Thank you :) |
cwperks
approved these changes
Dec 29, 2025
Collaborator
Author
|
@DarshitChanpura @shikharj05 @derek-ho @willyborankin would you be able to review this? merging this is needed to both unblock #5895 and #5827 |
5 tasks
shikharj05
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another PR for preparing the improved index resolution feature #5827 ; this adds new tests for the protected index feature. This allows us to easily test the new implementation in the future.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.