Refactor plugin system index tests to use parameterized test pattern#5895
Refactor plugin system index tests to use parameterized test pattern#5895cwperks merged 6 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: llilyy <llilyy0215@gmail.com>
5ece1ea to
926dc78
Compare
|
Thanks a lot for the changes. We have test failures, but I am pretty sure that these will be fixed as soon as #5865 is merged. |
c4fa5be to
acae5f1
Compare
Signed-off-by: llilyy <llilyy0215@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5895 +/- ##
==========================================
+ Coverage 73.67% 73.69% +0.01%
==========================================
Files 437 437
Lines 26655 26666 +11
Branches 3945 3947 +2
==========================================
+ Hits 19639 19651 +12
- Misses 5141 5143 +2
+ Partials 1875 1872 -3 🚀 New features to boost your workflow:
|
|
@nibix |
|
Hi, @cwperks! |
...est/java/org/opensearch/security/privileges/int_tests/AbstractPluginSystemIndexIntTests.java
Show resolved
Hide resolved
|
@llilyy minor comment on the javadoc, but otherwise lgtm. |
Signed-off-by: llilyy <llilyy0215@gmail.com>
|
@nibix |
nibix
left a comment
There was a problem hiding this comment.
Approved ...
I have retriggered one failed CI job, hopefully it will be green soon.
Description
Category
Refactoring
Why these changes are required?
Reviewer feedback suggested adopting the parameterized test suite pattern used in
IndexAuthorizationReadOnlyIntTests.javato improve test organization, reduce duplication, and ensure consistent behavior across different cluster configurations.What is the old behavior before changes and new behavior after changes?
Introduced a new
PluginSystemIndexIntTests.javaclass that uses JUnit's Parameterized runner.Issues Resolved
#5893
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.