DNM: CORENET-6864: allow for CNI version 1.1.0#278
DNM: CORENET-6864: allow for CNI version 1.1.0#278jluhrsen wants to merge 1 commit intoopenshift:mainfrom
Conversation
ovnk has updated to use v1.1.0 [0] and was getting rejected by multus as invalid. I noticed semver being used in pkg/server/config/generator.go so refactored to use that removing the hardcoded version checks and using v0.3.0 as the threshold [0] ovn-kubernetes/ovn-kubernetes@845456d Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
|
@jluhrsen: This pull request references CORENET-6864 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jluhrsen The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
the following test cases are duplicated with test that will run with the ovnk OTE work which will be enabled with this PR [0]. they are failing because upstream OVNK has bumped it's CNI version to 1.1.0 and these tests are hardcoded here (or in multus [1]) and don't accept 1.1.0 yet. The upstream change in ovnk also updated it's tests so when they run via OTE, they will pass. [0] openshift#30560 [1] openshift/multus-cni#278 Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
|
/test e2e-aws |
|
/close |
|
@jluhrsen: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@jluhrsen: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jluhrsen: This pull request references CORENET-6864 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
jluhrsen
changed the title
|
@jluhrsen: This PR was included in a payload test run from openshift/origin#30560
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/957eef30-16bd-11f1-8ef6-8f3a336991c0-0 |
|
/close |
|
@jluhrsen: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
the following test cases are duplicated with test that will run with the ovnk OTE work which will be enabled with this PR [0]. they are failing because upstream OVNK has bumped it's CNI version to 1.1.0 and these tests are hardcoded here (or in multus [1]) and don't accept 1.1.0 yet. The upstream change in ovnk also updated it's tests so when they run via OTE, they will pass. [0] openshift#30560 [1] openshift/multus-cni#278 Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
2 participants
ovnk has updated to use v1.1.0 [0] and was getting rejected by multus as invalid. I noticed semver being used in pkg/server/config/generator.go so refactored to use that removing the hardcoded version checks and using v0.3.0 as the threshold
[0] ovn-kubernetes/ovn-kubernetes@845456d