Merge https://github.com/openshift/oadp-must-gather:oadp-dev (5ce8bb8) into oadp-dev#81
Conversation
WalkthroughGo toolchain upgraded from version 1.23.x to 1.25.0. Direct and indirect dependencies updated across Kubernetes client libraries, Azure tooling, Prometheus modules, and ecosystem packages to align with newer API surfaces and compatibility requirements. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @oadp-rebasebot-app[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 69: The go.mod entry for module "github.com/gorilla/websocket" currently
pins an unreleased pseudo-version (v1.5.4-0.20250319132907-e064f32e3674); either
change that require line to the latest stable tag "v1.5.3" or, if you truly need
that specific unreleased commit, replace the pseudo-version with the same value
but add a clear comment explaining why it’s required and include a link to the
upstream PR/issue tracking the v1.5.4 release (reference the module name
"github.com/gorilla/websocket" and the pseudo-version string when editing).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e19d494a-d8a7-4a25-ba58-568a5e292231
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect | ||
| github.com/google/uuid v1.6.0 // indirect | ||
| github.com/gorilla/websocket v1.5.0 // indirect | ||
| github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What is the latest stable tagged release of gorilla/websocket and are there any known issues with version 1.5.3 or 1.5.4?
💡 Result:
- Latest stable tagged release: v1.5.3 (tagged Jun 14, 2024). [1][2]
- Is there a stable v1.5.4? No—there’s no v1.5.4 tag/release in the upstream repo; there’s an open request to “Release 1.5.4 with https proxy support”. [3] (Some projects reference an unreleased pseudo-version like
v1.5.4-0.20250319132907-e064f32e3674.) [4]
Known reported issues around v1.5.3 / “v1.5.4”
- v1.5.3 release notes vs reality: An open bug report says v1.5.3 release notes claim
hideTempErrwas removed, but it still appears (due to a revert), so users upgrading to avoidhideTempErrpanics may not get that benefit. [5] - Examples/docs: The chat example is reported broken unless
CheckOriginis implemented/adjusted. [6] - Toolchain compatibility/testing: A reported issue shows unit tests failing with Go 1.24 (
TestPreparedMessage). [7]
Sources:
[1] GitHub tags list (shows v1.5.3 as latest tag, dated Jun 14, 2024) (github.com)
[2] pkg.go.dev (shows module version v1.5.3, published Jun 14, 2024) (pkg.go.dev)
[3] GitHub issue requesting “Release 1.5.4 with https proxy support” (github.com)
[4] GitLab omnibus component list referencing pseudo-version v1.5.4-0... (gitlab-org.gitlab.io)
[5] GitHub issue: v1.5.3 release notes claim hideTempErr removed but it isn’t (github.com)
[6] GitHub issue: chat example does not work (CheckOrigin) (github.com)
[7] GitHub issue: unit test fails with Go 1.24 (github.com)
Citations:
- 1: https://github.com/gorilla/websocket/tags
- 2: https://pkg.go.dev/github.com/gorilla/websocket
- 3: [FEATURE] Release 1.5.4 with https proxy support gorilla/websocket#1006
- 4: https://gitlab-org.gitlab.io/omnibus-gitlab/gitlab-ee/18.5/18.5.1-ee.0.html?utm_source=openai
- 5: [BUG] v1.5.3 release notes say hideTempErr has been removed under #894, but it isn't gorilla/websocket#990
- 6: [BUG] Chat example does not work gorilla/websocket#986
- 7: [BUG] unit test fails with Go 1.24 gorilla/websocket#983
Replace pseudo-version with stable release or document justification.
The dependency uses an unreleased pseudo-version v1.5.4-0.20250319132907-e064f32e3674. The latest stable tagged release is v1.5.3 (June 14, 2024); v1.5.4 has not been officially released. Using unreleased commits in production dependencies introduces maintenance and stability risks. Either downgrade to v1.5.3 or, if this specific unreleased version is required for a critical fix or feature, add a comment documenting the reason and link to the upstream PR/issue tracking the eventual v1.5.4 release.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 69, The go.mod entry for module
"github.com/gorilla/websocket" currently pins an unreleased pseudo-version
(v1.5.4-0.20250319132907-e064f32e3674); either change that require line to the
latest stable tag "v1.5.3" or, if you truly need that specific unreleased
commit, replace the pseudo-version with the same value but add a clear comment
explaining why it’s required and include a link to the upstream PR/issue
tracking the v1.5.4 release (reference the module name
"github.com/gorilla/websocket" and the pseudo-version string when editing).
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc, oadp-rebasebot-app[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@oadp-rebasebot-app[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary by CodeRabbit