-
Notifications
You must be signed in to change notification settings - Fork 7
Merge https://github.com/openshift/oadp-must-gather:oadp-dev (5ce8bb8) into oadp-dev #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oadp-rebasebot-app
wants to merge
1
commit into
openshift:oadp-dev
Choose a base branch
from
oadp-rebasebot:rebase-bot-oadp-dev
base: oadp-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
What is the latest stable tagged release of gorilla/websocket and are there any known issues with version 1.5.3 or 1.5.4?💡 Result:
v1.5.4-0.20250319132907-e064f32e3674.) [4]Known reported issues around v1.5.3 / “v1.5.4”
hideTempErrwas removed, but it still appears (due to a revert), so users upgrading to avoidhideTempErrpanics may not get that benefit. [5]CheckOriginis implemented/adjusted. [6]TestPreparedMessage). [7]Sources:
[1] GitHub tags list (shows v1.5.3 as latest tag, dated Jun 14, 2024) (github.com)
[2] pkg.go.dev (shows module version v1.5.3, published Jun 14, 2024) (pkg.go.dev)
[3] GitHub issue requesting “Release 1.5.4 with https proxy support” (github.com)
[4] GitLab omnibus component list referencing pseudo-version
v1.5.4-0...(gitlab-org.gitlab.io)[5] GitHub issue: v1.5.3 release notes claim
hideTempErrremoved but it isn’t (github.com)[6] GitHub issue: chat example does not work (CheckOrigin) (github.com)
[7] GitHub issue: unit test fails with Go 1.24 (github.com)
Citations:
Replace pseudo-version with stable release or document justification.
The dependency uses an unreleased pseudo-version
v1.5.4-0.20250319132907-e064f32e3674. The latest stable tagged release is v1.5.3 (June 14, 2024); v1.5.4 has not been officially released. Using unreleased commits in production dependencies introduces maintenance and stability risks. Either downgrade to v1.5.3 or, if this specific unreleased version is required for a critical fix or feature, add a comment documenting the reason and link to the upstream PR/issue tracking the eventual v1.5.4 release.🤖 Prompt for AI Agents