refactor: extract StorageInterface protocol and add InProcessStorageControllerHandle#1126
Open
vringar wants to merge 3 commits intorefactor/extract-command-contextfrom
Open
refactor: extract StorageInterface protocol and add InProcessStorageControllerHandle#1126vringar wants to merge 3 commits intorefactor/extract-command-contextfrom
vringar wants to merge 3 commits intorefactor/extract-command-contextfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (36.94%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## refactor/extract-command-context #1126 +/- ##
====================================================================
- Coverage 44.03% 36.94% -7.10%
====================================================================
Files 37 39 +2
Lines 3522 3611 +89
====================================================================
- Hits 1551 1334 -217
- Misses 1971 2277 +306 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6b6daf0 to
536eb98
Compare
aa79ddd to
d333dbf
Compare
536eb98 to
1be210b
Compare
d333dbf to
f286084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StorageInterfaceprotocol fromStorageControllerHandleInProcessStorageControllerHandlethat runs the StorageController asyncio loop in a daemon thread instead of a subprocess, eliminating process spawn overhead for testsThe extension connects to it identically (same TCP protocol). Production code is unchanged.
Stacked on #1125.