Skip to content

Comments

refactor: extract StorageInterface protocol and add InProcessStorageControllerHandle#1126

Open
vringar wants to merge 3 commits intorefactor/extract-command-contextfrom
refactor/storage-interface
Open

refactor: extract StorageInterface protocol and add InProcessStorageControllerHandle#1126
vringar wants to merge 3 commits intorefactor/extract-command-contextfrom
refactor/storage-interface

Conversation

@vringar
Copy link
Contributor

@vringar vringar commented Feb 19, 2026

Summary

  • Extract StorageInterface protocol from StorageControllerHandle
  • Add InProcessStorageControllerHandle that runs the StorageController asyncio loop in a daemon thread instead of a subprocess, eliminating process spawn overhead for tests

The extension connects to it identically (same TCP protocol). Production code is unchanged.

Stacked on #1125.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.94%. Comparing base (1be210b) to head (971a1b8).

Files with missing lines Patch % Lines
openwpm/storage/in_process_storage.py 0.00% 79 Missing ⚠️
openwpm/storage/storage_interface.py 0.00% 10 Missing ⚠️

❌ Your project check has failed because the head coverage (36.94%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (1be210b) and HEAD (971a1b8). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (1be210b) HEAD (971a1b8)
5 1
Additional details and impacted files
@@                         Coverage Diff                          @@
##           refactor/extract-command-context    #1126      +/-   ##
====================================================================
- Coverage                             44.03%   36.94%   -7.10%     
====================================================================
  Files                                    37       39       +2     
  Lines                                  3522     3611      +89     
====================================================================
- Hits                                   1551     1334     -217     
- Misses                                 1971     2277     +306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vringar vringar force-pushed the refactor/extract-command-context branch from 6b6daf0 to 536eb98 Compare February 20, 2026 12:17
@vringar vringar force-pushed the refactor/storage-interface branch from aa79ddd to d333dbf Compare February 20, 2026 12:17
@vringar vringar changed the base branch from refactor/extract-command-context to master February 20, 2026 12:21
@vringar vringar changed the base branch from master to refactor/extract-command-context February 20, 2026 12:24
@vringar vringar force-pushed the refactor/extract-command-context branch from 536eb98 to 1be210b Compare February 20, 2026 12:41
@vringar vringar force-pushed the refactor/storage-interface branch from d333dbf to f286084 Compare February 20, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant